#11416 closed defect (fixed)
graphviz Portfile on Panther uses busted regexp
| Reported by: | yaseppochi (Stephen J. Turnbull) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt), markd@…,yaseppochi (Stephen J. Turnbull) | |
| Port: |
Description
This snippet from the darwin 7 platform code
post-extract {
reinplace "s|regex.h|gnuregex.h|g" ${worksrcpath}/lib/gvc/gvconfig.c
}
results in gvconfig.c containing
#include <gnugnuregex.h>
I'm not sure if the reinplace is somehow executed multiple times or (more likely IMO) upstream has decided to use gnuregex.h and not regex.h. Changing the snippet above to
post-extract {
reinplace "s|<regex.h>|<gnuregex.h>|g" ${worksrcpath}/lib/gvc/gvconfig.c
}
works for me. (NB I've fiddled the whitespace to format reasonably in trac.)
Change History (9)
comment:1 Changed 17 years ago by pipping@…
| Milestone: | → Available Ports |
|---|
comment:2 Changed 17 years ago by jmpp@…
| Component: | base → ports |
|---|---|
| Milestone: | Available Ports → Port Bugs |
| Priority: | Blocker → Expected |
comment:3 Changed 17 years ago by yaseppochi (Stephen J. Turnbull)
comment:4 Changed 17 years ago by cssdev
| Owner: | changed from macports-dev@… to ryandesign@… |
|---|
Assigning to the port maintainer.
comment:5 Changed 17 years ago by markd@…
| Cc: | ryandesign@… markd@… added |
|---|
CC maintainer since assigning doesn't do this automatically.
comment:6 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | stephen@… added |
|---|
Ccing reported.
MacPorts still supports Panther so this bug will be fixed.
comment:8 Changed 17 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
No, upstream is still using "#include <regex.h>". However MacPorts until recently had a bug where sometimes it would execute a phase, in this case the post-extract phase, twice, which would result in the behavior you observed. This should not happen anymore in current MacPorts, but I've made your suggested change anyway in r25479 because I like it.
I no longer support users of Panther, so I've upgraded to Tiger myself. You can close this as far as I'm concerned.