Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#11416 closed defect (fixed)

graphviz Portfile on Panther uses busted regexp

Reported by: yaseppochi (Stephen J. Turnbull) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: ryandesign (Ryan Schmidt), markd@…,yaseppochi (Stephen J. Turnbull)
Port:

Description

This snippet from the darwin 7 platform code

post-extract {
              reinplace "s|regex.h|gnuregex.h|g" ${worksrcpath}/lib/gvc/gvconfig.c
             }

results in gvconfig.c containing

#include <gnugnuregex.h>

I'm not sure if the reinplace is somehow executed multiple times or (more likely IMO) upstream has decided to use gnuregex.h and not regex.h. Changing the snippet above to

post-extract {
              reinplace "s|<regex.h>|<gnuregex.h>|g" ${worksrcpath}/lib/gvc/gvconfig.c
             }

works for me. (NB I've fiddled the whitespace to format reasonably in trac.)

Change History (9)

comment:1 Changed 14 years ago by pipping@…

Milestone: Available Ports

comment:2 Changed 14 years ago by jmpp@…

Component: baseports
Milestone: Available PortsPort Bugs
Priority: BlockerExpected

comment:3 Changed 14 years ago by yaseppochi (Stephen J. Turnbull)

I no longer support users of Panther, so I've upgraded to Tiger myself. You can close this as far as I'm concerned.

comment:4 Changed 14 years ago by cssdev

Owner: changed from macports-dev@… to ryandesign@…

Assigning to the port maintainer.

comment:5 Changed 14 years ago by markd@…

Cc: ryandesign@… markd@… added

CC maintainer since assigning doesn't do this automatically.

comment:6 Changed 14 years ago by ryandesign (Ryan Schmidt)

Cc: stephen@… added

Ccing reported.

MacPorts still supports Panther so this bug will be fixed.

comment:7 Changed 14 years ago by ryandesign (Ryan Schmidt)

ReporteR. Ccing reporteR.

comment:8 Changed 14 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

No, upstream is still using "#include <regex.h>". However MacPorts until recently had a bug where sometimes it would execute a phase, in this case the post-extract phase, twice, which would result in the behavior you observed. This should not happen anymore in current MacPorts, but I've made your suggested change anyway in r25479 because I like it.

comment:9 Changed 12 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.