Opened 17 years ago

Closed 17 years ago

Last modified 15 years ago

#11811 closed enhancement (fixed)

lua - add universal variant

Reported by: meissnem@… Owned by: pmq@…
Priority: Low Milestone:
Component: ports Version:
Keywords: Cc: meissnem@…, pmq@…
Port:

Description

short patch to enable lua to be built universal.

Attachments (3)

lua-universal.patch (469 bytes) - added by meissnem@… 17 years ago.
patchfile
with-and-without-universal.diff (3.0 KB) - added by meissnem@… 17 years ago.
lua-patch (764 bytes) - added by meissnem@… 17 years ago.
Lua +universal patch, mark 2

Download all attachments as: .zip

Change History (11)

Changed 17 years ago by meissnem@…

Attachment: lua-universal.patch added

patchfile

comment:1 Changed 17 years ago by pipping@…

although this might be the right way to go enventually, this is not ready to be committed!

the patch overrides the post-patch stage and important 'reinplace'-calls with it.

Changed 17 years ago by meissnem@…

comment:2 Changed 17 years ago by meissnem@…

On my system at least (macports 1.4.3, Intel iMac), the +universal variant APPENDS to the post-patch phase. So the original reinplace calls are left in tact, and the new ones simply augment the MYCFLAGS and MYLDFLAGS lines.

I'm attaching a new diff. It's the difference between the source tree when doing "port patch" and "port patch +universal". Notice that luaconf.h and etc/lua.pc are identical, and Makefile contains the changes from both "post-patch" sections.

comment:3 Changed 17 years ago by pmq@…

Milestone: Port Enhancements
Status: newassigned

comment:4 Changed 17 years ago by pmq@…

Cc: pmq@… added
Summary: [patch] lua - add universal variantPATCH: lua - add universal variant
Type: defectenhancement

OK, as I have to admit I don't know anything about the current MP state regarding +universal, isn't there a better way to do this, possibly using some ${configure-universal-flags} variable, to avoid having the ugly -isysroot in the Portfile?

comment:5 Changed 17 years ago by meissnem@…

Ports that specify "use_configure no" do not have the configure.universal_* variables set, so I didn't use them in this portfile.

I'm attaching an alternate patch that removes "use_configure no" and creates a configure{} function using the variables -- thereby removing the -isysroot ugliness.

Let me know what you think.

Changed 17 years ago by meissnem@…

Attachment: lua-patch added

Lua +universal patch, mark 2

comment:6 Changed 17 years ago by pmq@…

Resolution: fixed
Status: assignedclosed

Thanks a lot for your work! It is now committed.

comment:7 Changed 17 years ago by nox@…

Priority: Nice to haveLow
Summary: PATCH: lua - add universal variantlua - add universal variant

comment:8 Changed 15 years ago by (none)

Milestone: Port Enhancements

Milestone Port Enhancements deleted

Note: See TracTickets for help on using tickets.