Opened 17 years ago

Closed 17 years ago

Last modified 15 years ago

#12008 closed update (fixed)

RENAME/UPDATE: Git 1.5.2

Reported by: zacheryph@… Owned by: macports-tickets@…
Priority: High Milestone:
Component: ports Version: 1.4.42
Keywords: git scm git-core cogito Cc: bryan@…, zacheryph@…, boeyms@…
Port:

Description

This renames git to its rightful name (git-core -> git) as its no longer called git-core and is a product in its own right.

  • delete_git-core.patch: removed devel/git-core
  • add_git.patch: adds devel/git with proper updates from git-core to handle new package version
  • update_cogito.patch: update cogito to depend on git instead of git-core.

currently the docs does not work as xslt parcer tries pulling a file from sf.net, im hoping this might be temprary, if anyone knows so, or a way to fix it please tell me.

Attachments (3)

delete_git-core.patch (5.7 KB) - added by zacheryph@… 17 years ago.
removed devel/git-core
update_cogito.patch (401 bytes) - added by zacheryph@… 17 years ago.
updates cogito to depend on git not git-core
add_git.patch (4.1 KB) - added by zacheryph@… 17 years ago.
fix man page install, remove old dependancies

Download all attachments as: .zip

Change History (8)

Changed 17 years ago by zacheryph@…

Attachment: delete_git-core.patch added

removed devel/git-core

Changed 17 years ago by zacheryph@…

Attachment: update_cogito.patch added

updates cogito to depend on git not git-core

comment:1 Changed 17 years ago by zacheryph@…

This patch shows me as maintainer, though should prolly say bryan and me. other notes:

  • this nullifies Ticket #11962 and can be closed will not fix. i added a comment on there as well.
  • i removed NO_DARWIN_PORTS from args list as i didn't see a reason for being there, and runs perfectly fine with it removed.

comment:2 Changed 17 years ago by bryan@…

Certainly git is probably a better name than git-core (which was the right name in 2005 when I first created the Portfile), but there are lots of users of this port, most of whom won't get the upgrade if we change the name. So, IMHO, the name change does more harm than good. It's not a surprising name, it's what the Linux distributions use.

FYI, NO_DARWIN_PORTS is technically correct. At one time it was required, but now it isn't. NO_DARWIN_PORTS means don't add the flags necessary to use the MacPorts libraries. The port system has already added these flags, so doing it twice is (potentially, but not in this case) problematic.

Changed 17 years ago by zacheryph@…

Attachment: add_git.patch added

fix man page install, remove old dependancies

comment:3 Changed 17 years ago by boeyms@…

Cc: zacheryph@… boeyms@… added
Resolution: fixed
Status: newclosed

I've committed patch-11962-7333 from #11962 in r25898, which contains the version bump.

Since the list of maintainers for the git-core port does not contain the openmaintainer@... address, the people who maintain the port and how it is maintained is at the discretion of the currently listed maintainer(s) (in this case Bryan).

I don't use git, so I don't feel qualified to say anything about whether or not the port should be renamed. If the maintainer finds it interesting, however, Randall Wood has implemented automated replacement for ports including colorscheme, hicolor-icon-theme and docbook-xml-412, so it can be done. Note that the approach in the latter of these is probably safer (I had problems with port hanging after trialling on another port the automated uninstallation scheme used in the first two), but it does mean that the user will have to manually remove the obsoleted port.

Thanks nonetheless to zacheryph for bringing the update to our attention; I look forward to seeing more patch submissions from you!

comment:4 Changed 15 years ago by jmroot (Joshua Root)

Type: enhancementupdate

comment:5 Changed 15 years ago by (none)

Milestone: Port Updates

Milestone Port Updates deleted

Note: See TracTickets for help on using tickets.