Opened 17 years ago

Closed 17 years ago

Last modified 15 years ago

#12089 closed defect (duplicate)

BUG: git-core port should require p5-error

Reported by: giulio.eulisse@… Owned by: mgrimes@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: bryan@…
Port:

Description

In order to work, git-remote needs Error.pm

Change History (7)

comment:1 Changed 17 years ago by kballard (Lily Ballard)

Cc: bryan@… added

If the maintainer (CC'ed) doesn't respond within 3 days, contact me and I'll handle this.

comment:2 Changed 17 years ago by bryan@…

This can be fixed by adding port:perl and port:p5-error to the list of dependencies. This may be appropriate for the svn variant (which already requires port:perl), but I'd hate to require the huge perl dependency when it shouldn't be required (Apple's stock perl should be good enough.)

The git installer is supposed to install a private-Error.pm if it cannot find Error.pm. This appears to be broken in the latest rev.

comment:3 Changed 17 years ago by bryan@…

When perl is installed but p5-error isn't, git installs Error.pm into /opt/local/lib/perl5/site_perl/5.8.8/Error.pm. This is fine, but rude.

When perl isn't installed, Error.pm is installed into /opt/local/lib/perl5/site_perl/Error.pm. This is not accessible from Apple perl without playing with INC paths.

Only one test t5502 uses git remote. Unfortunately, t5502 passes when neither perl5.8 nor p5-error are installed.

p5-error puts Error.pm in /opt/local/lib/perl5/vendor_perl/5.8.8/Error.pm.

comment:4 Changed 17 years ago by mgrimes@…

Keywords: git-core added
Owner: changed from macports-dev@… to mgrimes@…

I've left this for svn variant only for now so that we can deal with the fallout of people trying to "git behind svn" (no pun intended). How would you like to handle this? (partial fix so long as you can deal with the svn dep in r26771.) -- leaving this ticket open.

comment:5 Changed 17 years ago by nox@…

Milestone: Port Bugs
Priority: ExpectedNormal
Summary: git-core port should require p5-errorBUG: git-core port should require p5-error
Version: 1.4.40

comment:6 Changed 17 years ago by mgrimes@…

Keywords: git-core removed
Resolution: duplicate
Status: newclosed

Dupe with further discussion in #12624. Maybe fixed in r28705.

comment:7 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.