Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#12174 closed defect (fixed)

Unnecessary build.env in sqlite3 Portfile

Reported by: jmpp@… Owned by: mww@…
Priority: Normal Milestone:
Component: ports Version: 1.4.40
Keywords: Cc: mww@…, jmpp@…
Port:

Description

The current SQLite3 Portfile defines the following build environment:

build.env               CFLAGS="-I${prefix}/include/ -DSQLITE_ENABLE_LOCKING_STYLE=1" \
                                LDFLAGS="-L${prefix}/lib"

I tried building without the -I${prefix}/include/ and -L${prefix}/lib declarations and found linkage of the build results to be unaltered, so Id' say those can be safely removed (MacPorts now passes them by default out of the box). In doing that, I moved the remaining compiler macro to the configure environment following the new syntax:

configure.cflags-append                -DSQLITE_ENABLE_LOCKING_STYLE=1

But also found that that's rather unnecessary, as SQLite3's build magic still passes that particular compiler macro to the build calls even if we don't list it explicitly in CFLAGS. The attached Portfile patch moves the macro to configure.env per the syntax above even if for safety, but I would say we're safe removing it altogether (the attached destroot.log file catches all the output of the destroot run and demonstrates the macro is being passed even though it's neither in configure.env, DEBUG: Environment: CXXFLAGS='-O2' CPPFLAGS='-I/opt/local/include' CFLAGS='-O2' LDFLAGS='-L/opt/local/lib', nor in build.env, DEBUG: Environment:).

-jmpp

Attachments (2)

Portfile.diff (434 bytes) - added by jmpp@… 12 years ago.
destroot.log (49.9 KB) - added by jmpp@… 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by jmpp@…

Attachment: Portfile.diff added

Changed 12 years ago by jmpp@…

Attachment: destroot.log added

comment:1 Changed 12 years ago by jmpp@…

Milestone: Port EnhancementsPort Bugs

Committed in r26620 due to maintainer timeout.

-jmpp

comment:2 Changed 12 years ago by jmpp@…

Resolution: fixed
Status: newclosed

comment:3 Changed 11 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.