Opened 13 years ago

Closed 10 years ago

#12231 closed defect (fixed)

BUG: tcl sqlite3 default directory

Reported by: afb@… Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts 1.9.0
Component: base Version: 1.5
Keywords: FreeBSD support, Linux support Cc:
Port:

Description

Currentl value (/usr/lib/sqlite3) hardcoded for Darwin, provide some more OS alternatives...

Attachments (2)

macports-tclsqlite3.patch (832 bytes) - added by afb@… 13 years ago.
macports-tclsqlite3.patch
macports-tclsqlite3.2.patch (1.7 KB) - added by afb@… 13 years ago.
macports-tclsqlite3.patch

Download all attachments as: .zip

Change History (17)

Changed 13 years ago by afb@…

Attachment: macports-tclsqlite3.patch added

macports-tclsqlite3.patch

comment:1 Changed 13 years ago by kballard (Lily Ballard)

It seems the entire point of this is to provide a sane default for FreeBSD. I'm not sure we want to do this. We've already decided that MacPorts assumes the user is running on Darwin, and so we can rely on Darwin-specific things, like in this case the location of sqlite3. If you want to override it that's what the --with-tcl-sqlite3 configure switch is for. While it doesn't hurt anything to accept this patch for the short term, I'm worried about this setting a precedent that reverses our previous decision.

Anybody else have an opinion?

comment:2 Changed 13 years ago by landonf (Landon Fuller)

I agree that --with-tcl-sqlite3 is the better way to override this on a per-OS basis.

I do disagree on the notion of relying on Darwin-specific paths, as hard-coded paths tend to break ... but in this case, it's just a default, so I don't see an issue.

comment:3 Changed 13 years ago by afb@…

The only reason for providing defaults was to make "selfupdate" work. As there are no releases since MacPorts 1.4.0, that's the recommended way of installing 1.4.40-42 or the new 1.5/SVN.

comment:4 Changed 13 years ago by jmpp@…

Milestone: Needs developer review

comment:5 Changed 13 years ago by afb@…

As noted above, the patch doesn't change anything for Mac OS X.

comment:6 Changed 13 years ago by kballard (Lily Ballard)

ok, if this is necessary for selfupdate to work then I'm ok with us accepting the change.

comment:7 Changed 13 years ago by jmpp@…

Keywords: FreeBSD support added

comment:8 Changed 13 years ago by jmpp@…

Milestone: Needs developer reviewMacPorts base bugs

Milestone Needs developer review deleted

comment:9 Changed 13 years ago by nox@…

Priority: ExpectedNormal
Summary: tcl sqlite3 default directoryBUG: tcl sqlite3 default directory

comment:10 Changed 13 years ago by afb@…

Keywords: Linux added

The last clause works on Linux, it seems.

comment:11 Changed 13 years ago by afb@…

Scratch last comment, each Linux distro has it's own install location. :-(

Configure needs to fall back on the internal version, if no system tcl-sqlite3 can be found. With the current script, you end up with:

SQLITE3_DIR=''
SQLITE3_LIBS='-lsqlite3'

Probably rather useless.

comment:12 Changed 13 years ago by afb@…

Provided that the sqlite3 libraries are found (but not tcl), it might be possible to use those to build the tcl module with (rather than building the internal/static library)

Changed 13 years ago by afb@…

Attachment: macports-tclsqlite3.2.patch added

macports-tclsqlite3.patch

comment:13 Changed 13 years ago by afb@…

Updated patch to fall back on the internal version, don't seem you can build against system libs.

comment:14 Changed 12 years ago by tobypeterson

Milestone: MacPorts base bugsMacPorts Future

Milestone MacPorts base bugs deleted

comment:15 Changed 10 years ago by jmroot (Joshua Root)

Milestone: MacPorts FutureMacPorts 1.9.0
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.