Opened 14 years ago

Last modified 7 years ago

#12247 new defect

BUG: Makefiles require GNU make

Reported by: afb@… Owned by: macports-tickets@…
Priority: Low Milestone: MacPorts Future
Component: base Version: 1.5
Keywords: FreeBSD support Cc: cooljeanius (Eric Gallager), larryv (Lawrence Velázquez)
Port:

Description

The makefiles use some commands specific to GNU make, and don't work with BSD make.

Attachments (1)

macports-bsdmake.patch (1.7 KB) - added by afb@… 14 years ago.
macports-bsdmake.patch

Download all attachments as: .zip

Change History (11)

Changed 14 years ago by afb@…

Attachment: macports-bsdmake.patch added

macports-bsdmake.patch

comment:1 Changed 14 years ago by jmpp@…

Milestone: Needs developer review

Comments on the patch:

  • For consistency's sake, would like to see a line like [ "$(ARC)" = "yes" ] && ${MAKE} SVNTAG=${DISTARCTAG} PKGNAME=${DISTARCNAME} _dopkg in base/Makefile.in rather than the one provided using test explicitly;
  • Not sure if removing ifneq ($(MAKECMDGOALS),distclean) from base/doc/Makefile has any negative side effects, I haven't been able to spot any;
  • Not sure why we're exporting the deployment target in base/src/pextlib1.0 and in base/src/tclobjc1.0 and if removing the export keyword breaks anything, I'll let others chime in on that one.

Other than those three, the patch seems OK to me for inclusion.

-jmpp

comment:2 Changed 14 years ago by jmpp@…

Keywords: FreeBSD support added

comment:3 Changed 14 years ago by afb@…

"Not sure if removing ifneq ($(MAKECMDGOALS),distclean) from base/doc/Makefile has any negative side effects, I haven't been able to spot any;"

Don't think it should have any, since doc/Makefile is processed before rm -f Mk/macports.autoconf.mk

comment:4 Changed 14 years ago by afb@…

Priority: ExpectedNice to have

comment:5 Changed 14 years ago by jmpp@…

Milestone: Needs developer reviewMacPorts base bugs

Milestone Needs developer review deleted

comment:6 Changed 14 years ago by nox@…

Priority: Nice to haveLow
Summary: Makefiles require GNU makeBUG: Makefiles require GNU make

comment:7 Changed 12 years ago by tobypeterson

Milestone: MacPorts base bugsMacPorts Future

Milestone MacPorts base bugs deleted

comment:8 Changed 8 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:9 Changed 7 years ago by cooljeanius (Eric Gallager)

The removal of the endifs would be useful not just for compatibility with BSD make, but also for people who might want to try converting the Makefiles to automake-generated ones: http://lists.gnu.org/archive/html/automake/2000-10/msg00107.html

comment:10 Changed 7 years ago by larryv (Lawrence Velázquez)

Cc: larryv@… added

Cc Me!

Note: See TracTickets for help on using tickets.