Opened 17 years ago

Closed 17 years ago

Last modified 15 years ago

#12308 closed defect (fixed)

[ufraw@0.11] Compile error in ufraw_exiv2.cc (line 204) when exiv2 support is actived

Reported by: xtoph@… Owned by: frank.mcpherson@…
Priority: High Milestone:
Component: ports Version: 1.5.0
Keywords: Cc: frank.mcpherson@…
Port:

Description

Hi,

Ufraw@0.11 required 'exiv2-config' file to detect exiv2. This file is not currently installed by exiv2@0.14_0.

So, i create it like this :

#!/bin/sh pkg-config --libs exiv2

I don't know if the 'exiv2-config' is deprecated or not. So may be the good solution is to used 'pkg-config' file in .configure.

When Exiv2 support is activated, the compile failed : "ufraw_exiv2.cc: In function 'int ufraw_exif_from_exiv2(ufraw_data*)': ufraw_exiv2.cc:204: error: request for member 'c_str' in '#'obj_type_ref' not supported by dump_expr#<expression error>((&(+ e)->Exiv2::AnyError::<anonymous>))', which is of non-class type 'c"

It's just a type mismatch error ! A solution is to rewrite the catch clause (line 204) :

std::cerr.rdbuf(savecerr); std::string str(e.what()); ufraw_message(UFRAW_SET_WARNING, "%s\n", str.c_str());

Regards Xtoph

Attachments (2)

patch-ufraw_api.cc (440 bytes) - added by frank.mcpherson@… 17 years ago.
patch-Portfile (844 bytes) - added by frank.mcpherson@… 17 years ago.

Download all attachments as: .zip

Change History (5)

Changed 17 years ago by frank.mcpherson@…

Attachment: patch-ufraw_api.cc added

Changed 17 years ago by frank.mcpherson@…

Attachment: patch-Portfile added

comment:1 Changed 17 years ago by frank.mcpherson@…

Thanks for pointing this out. Since your note, ufraw-0.12 was releasead, so I decided to get that working rather than to fix 0.11. It's a straightforward fix that just adds a patch to ufraw_api.cc to fix a missing include of sys/types.h on our platform.

comment:2 Changed 17 years ago by yves@…

Resolution: fixed
Status: newclosed

Committed -- thanks

changeset:27532

comment:3 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.