Opened 17 years ago

Closed 16 years ago

Last modified 15 years ago

#12597 closed enhancement (fixed)

ImageMagick: add +rsvg variant

Reported by: bulk@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.5.0
Keywords: Cc: jmroot (Joshua Root)
Port:

Description

Hi there,

I'd love to see a "+rsvg" variant for image magick. All it needs to do is add a dependency on 'librsvg' and ImageMagick does the rest (no additional commands/configure flags needed.. it auto detects it).

thanks,

--nickg

Change History (6)

comment:1 Changed 16 years ago by cssdev

Milestone: Port Enhancements

comment:2 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Summary: RFE ImageMagick: add +rsvg variantImageMagick: add +rsvg variant

I'll assign this to me, since I'm the ImageMagick maintainer. Not saying I'll resolve it immediately though.

Additional configure arguments are needed. Auto-detecting other packages is not appropriate for software installed using MacPorts. It would mean that two users would "magically" get two different versions of ImageMagick, simply if one user already had librsvg installed and the other did not. We don't want that. We want everyone who builds a port with a given set of variants to get the same software (modulo major OS versions and processor architectures). If ImageMagick auto-detects librsvg if installed, we need to add configure arguments to disable librsvg explicitly unless this new +rsvg variant is chosen.

comment:3 Changed 16 years ago by bulk@…

My point was it works just like all the other libraries in ImageMagick. assuming wikitext doesn't mangle the text, it's something like the following:

Add to configure.args:

  --without-rsvg

Since right now, it WILL use rsvg if you install librsvg first

add somewhere:

variant rsvg description {Include librsvg library support} {
    depends_lib-append  port:librsvg
    configure.args-delete    --without-rsvg
    configure.args-append   --with-rsvg
}

I hope this helps,

thanks,

-nickg

comment:4 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: jmr@… added

Has duplicate #15036 which has a patch which looks a lot like what bulk@modp wrote above.

comment:5 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

Committed the patch from #15036 in r36122. Thanks everyone.

comment:6 Changed 15 years ago by (none)

Milestone: Port Enhancements

Milestone Port Enhancements deleted

Note: See TracTickets for help on using tickets.