Opened 16 years ago

Closed 12 years ago

Last modified 12 years ago

#12919 closed enhancement (fixed)

php5: add sockets variant

Reported by: roger.hoover@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.5.2
Keywords: Cc: roger.hoover@…, ryandesign (Ryan Carsten Schmidt), jyrkiwahlstedt, ibadinov@…
Port: php5, php5-devel

Description

Currently, there is no way to include the "--enable-sockets" configure option when building php5. This patch adds a variant to support enabling sockets.

Attachments (1)

Portfile-php5.diff (496 bytes) - added by roger.hoover@… 16 years ago.
Patch to add sockets variant to php5

Download all attachments as: .zip

Change History (10)

Changed 16 years ago by roger.hoover@…

Attachment: Portfile-php5.diff added

Patch to add sockets variant to php5

comment:1 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: roger.hoover@… ryandesign@… jwa@… added
Summary: Port Update - adding sockets variant for php5php5: add sockets variant

Added sockets variant to php5 portfile in r30538 and to php5-devel portfile in r30539. I did not increment the port revision, since users who want the variant will have to reinstall with that variant anyway. Note that the socket functions will be moved to the PECL repository starting with PHP 5.3.0 and the sockets variant will be removed from the php5 and php5-devel portfiles at that time.

comment:2 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

comment:3 Changed 15 years ago by (none)

Milestone: Port Enhancements

Milestone Port Enhancements deleted

comment:4 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Port: php5 php5-devel added

The sockets functionality seems not to have been removed from php 5.3 after all, so I removed the statement in the variant to that effect in r53523.

comment:5 Changed 12 years ago by ibadinov@…

+sockets variant is missing in trunk again (((

comment:6 Changed 12 years ago by ibadinov@…

Resolution: fixed
Status: closedreopened

comment:7 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ibadinov@… added
Resolution: fixed
Status: reopenedclosed

The sockets variant was added years ago, as indicated above, thus this ticket is fixed.

Subsequently, this and other variants were removed and turned into separate ports, and then into subports. See #19091. Depending on which PHP port you use, install one of the following ports:

  • php5-sockets
  • php53-sockets
  • php54-sockets

comment:8 Changed 12 years ago by ibadinov@…

Yep, my mistake. Thank you for support.
But still there is one reason left to maintain local port: fix for E_STRICT (which is embedded in 5.4 only), but life without it is horrible. Or maybe someone already fixed it here? If not, is there rationale for opening new ticket?
It's only one line of code that needs to be changed:

--- a/Zend/zend_errors.h.orig   2012-05-03 16:54:59.000000000 +0300
+++ b/Zend/zend_errors.h        2012-06-25 18:12:13.000000000 +0300
@@ -38,7 +38,7 @@
 #define E_DEPRECATED           (1<<13L)
 #define E_USER_DEPRECATED      (1<<14L)
 
-#define E_ALL (E_ERROR | E_WARNING | E_PARSE | E_NOTICE | E_CORE_ERROR | E_CORE_WARNING | E_COMPILE_ERROR | E_COMPILE_WARNING | E_USER_ERROR | E_USER_WARNING | E_USER_NOTICE | E_RECOVERABLE_ERROR | E_DEPRECATED | E_USER_DEPRECATED)
+#define E_ALL (E_ERROR | E_WARNING | E_PARSE | E_NOTICE | E_CORE_ERROR | E_CORE_WARNING | E_COMPILE_ERROR | E_COMPILE_WARNING | E_USER_ERROR | E_USER_WARNING | E_USER_NOTICE | E_RECOVERABLE_ERROR | E_DEPRECATED | E_USER_DEPRECATED | E_STRICT)
 #define E_CORE (E_CORE_ERROR | E_CORE_WARNING)
 
 #endif /* ZEND_ERRORS_H */

comment:9 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

This ticket is closed. If you have enhancements you want implemented, please open a new ticket.

Note: See TracTickets for help on using tickets.