Opened 13 years ago

Closed 13 years ago

Last modified 11 years ago

#12958 closed enhancement (fixed)

port lint should check patchfile names

Reported by: ryandesign (Ryan Schmidt) Owned by: afb@…
Priority: Normal Milestone: MacPorts 1.6
Component: base Version: 1.6.0
Keywords: Cc: ryandesign (Ryan Schmidt), afb@…, nox@…


It would be nice if "port lint" were updated to issue warnings for any patchfile names (even patchfiles in variants) that do not follow the "patch-*.diff" naming convention.

See this thread on the mailing list.

Change History (6)

comment:1 Changed 13 years ago by nox@…

Resolution: fixed
Status: newclosed

Nice idea! r30160.

% sudo port lint 9e   
--->  Verifying Portfile for 9e
Warning: Patchfile patch-9e.c does not follow the source patch naming policy "patch-*.file"
--->  0 errors and 1 warnings found.

comment:2 Changed 13 years ago by nox@…

Cc: nox@… added

comment:3 Changed 13 years ago by afb@…

The patch is buggy, the warning says: "patch-*.file" (while it checks for patch-*.diff)

comment:4 Changed 13 years ago by ryandesign (Ryan Schmidt)

This typo was fixed in r30168.

comment:5 Changed 13 years ago by ryandesign (Ryan Schmidt)

The "even patchfiles in variants" part of this request seems not to have been entirely addressed. See #13825 which reiterates this request.

comment:6 Changed 11 years ago by jmroot (Joshua Root)

Milestone: MacPorts FutureMacPorts 1.6
Note: See TracTickets for help on using tickets.