Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#13263 closed enhancement (fixed)

lint: check that port name matches port directory name

Reported by: ryandesign (Ryan Schmidt) Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts 1.7.0
Component: base Version: 1.6.0
Keywords: Cc: afb@…, jmpp@…
Port:

Description

port lint should check whether the port name declared in the portfile matches the name of the directory the port resides in.

For example, the file devel/qtcsharp/Portfile says the port's name is qtsharp (missing the c). (Filed as #13262.) lint should catch this error.

Change History (7)

comment:1 Changed 10 years ago by afb@…

This one is more tricky, while it is generally true for the SVN ports tree, it's also possible to build ports from a developer snapshot or older version or maybe even from a portpkg in the future.

But it could be a warning.

comment:2 Changed 10 years ago by afb@…

Another example (from Ryan) is php5, it is listing categories in wrong order.

(says "lang php www" while it should be something like "www php lang" instead)

comment:3 Changed 10 years ago by afb@…

  • Resolution set to fixed
  • Status changed from new to closed

Fixed, r30996.

Made it an error for the time being, if portpkg building is added later it can be revised.

comment:4 Changed 10 years ago by jmpp@…

  • Component changed from ports to base

comment:5 Changed 10 years ago by ryandesign (Ryan Schmidt)

  • Cc afb@… jmpp@… added; ryandesign@… removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

r30996 did not implement the feature requested in this ticket. It checks that the port category matches the directory the port's in. That's good but not what this ticket requests. This ticket requests that the port name (defined with the name keyword in the portfile) is the same as the name of the directory the Portfile is in. See the original problem that triggered this request, as per the issue description above, and see another instance of the problem which was fixed in r33525 which it would be nice if port lint could have caught.

comment:6 Changed 10 years ago by afb@…

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed, r33560.

This should be backported for 1.6.1, must have misunderstood the ticket the first time...

comment:7 Changed 8 years ago by jmroot (Joshua Root)

  • Milestone changed from MacPorts Future to MacPorts 1.7.0
Note: See TracTickets for help on using tickets.