Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#13496 closed defect (fixed)

Lint complains if first line of Portfile is modeline

Reported by: rhwood@… Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts 1.7.0
Component: base Version: 1.6.0
Keywords: lint modeline Cc:
Port:

Description

For port gtk2, lint produces the following:

--->  Verifying Portfile for gtk2
Warning: Line 1 is missing RCS tag ($Id$)
--->  0 errors and 1 warnings found.

The first line of the port is a modeline.

Perhaps lint should be changed to recognize that if the 1st line is a modeline that the first three lines of the portfile should be:

modeline an empty line for readability the RCS tag

In addition, can lint recognize that the modeline is/or is not the standard modeline?

Change History (7)

comment:1 Changed 10 years ago by rhwood@…

modeline an empty line for readability the RCS tag

should read:

modeline
an empty line for readability
RCS tag

comment:2 Changed 10 years ago by milosh@…

Are modeline and RCS tags supposed to be readable by humans? I don't think they need to stand out this much and hence don't need an empty line between them.

comment:3 Changed 10 years ago by afb@…

  • Summary changed from Lint complains if first line of Portfile is a modeline to Lint complains if first line of Portfile is a newline

port lint does recognize the modeline gunk, it just doesn't like the newline between it and RCS... However, the error seems to be wrong, as it should be "Line 2 is missing RCS tag".

comment:4 Changed 10 years ago by ryandesign (Ryan Schmidt)

  • Summary changed from Lint complains if first line of Portfile is a newline to Lint complains if first line of Portfile is modeline

comment:5 Changed 10 years ago by afb@…

  • Resolution set to fixed
  • Status changed from new to closed

Fixed, r32480.

comment:6 Changed 9 years ago by tobypeterson

  • Milestone changed from MacPorts base bugs to MacPorts Future

Milestone MacPorts base bugs deleted

comment:7 Changed 8 years ago by jmroot (Joshua Root)

  • Milestone changed from MacPorts Future to MacPorts 1.7.0
Note: See TracTickets for help on using tickets.