Opened 13 years ago

Closed 13 years ago

Last modified 11 years ago

#13692 closed update (fixed)

Updated Logtalk portfile to version 2.31.0

Reported by: pmoura (Paulo Moura) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.5.2
Keywords: Cc: ryandesign (Ryan Schmidt)
Port:

Description

Updated Logtalk portfile to version 2.31.0.

Attachments (1)

Portfile-logtalk.diff (2.3 KB) - added by pmoura (Paulo Moura) 13 years ago.

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by pmoura (Paulo Moura)

Attachment: Portfile-logtalk.diff added

comment:1 Changed 13 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…

comment:2 Changed 13 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

Based on the first line of the attached diff, your patch is based on r31023 of the Portfile and rolls it back to r26918, and then presumably makes some additional changes. That's weird. In particular, you're undoing two changes from r30998 which removed the unnecessary "extract.suffix" line and which changed "configure {}" to "use_configure no". I assume you didn't mean to do that, so I just made these changes:

  • r32260: compute distfile name rather than repeat the version number
  • r32262: no longer use deprecated cd command
  • r32263: update to version 2.31.0

For future updates, make sure you get an unmodified copy of the current version of the Portfile, make a copy of it (call it Portfile.orig), then make changes to the Portfile, and once you're happy with your changes, compute the diff between those two files with diff -u Portfile.orig Portfile and attach that to a ticket, after reading it of course and making sure that every change is one that you actually want made to the Portfile. :)

comment:3 Changed 11 years ago by jmroot (Joshua Root)

Type: defectupdate

comment:4 Changed 11 years ago by (none)

Milestone: Port Updates

Milestone Port Updates deleted

Note: See TracTickets for help on using tickets.