Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#13932 closed submission (fixed)

Update InsightToolkit port

Reported by: peter@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Insight Toolkit Cc: p.schmiedeskamp@…, raimue (Rainer Müller)
Port:

Description

Hi, a while back I submitted a port for inclusion (ticket 12413). Since that time the software has been updated. Here is a working, updated port.

From the discussion on port 12413, I have updated the way the cmake build dependency is listed to include the port cmake instead of just requiring the cmake binary. I assume this is the correct way of doing this now that cmake-devel has been removed as a port.

The port seems to work correctly on my system. Please let me know if I've missed anything.

Attachments (1)

Portfile (1.0 KB) - added by peter@… 16 years ago.

Download all attachments as: .zip

Change History (13)

Changed 16 years ago by peter@…

Attachment: Portfile added

comment:1 Changed 16 years ago by raimue (Rainer Müller)

Cc: p.schmiedeskamp@… raimue@… added

Would have been much better if you would have submitted this in form of a patch.

Adding maintainer to CC.

comment:2 Changed 16 years ago by raimue (Rainer Müller)

Sorry, please ignore my previous comment. I understood this wrong, this is a submission, not a port update... Why didn't you call the port itk? I don't like case-sensitive port names and they are known to cause trouble.

comment:3 Changed 16 years ago by peter@…

There is already an unrelated itk port. I followed FreeBSD's port naming convention given that the name itk was taken: http://www.freebsd.org/cgi/cvsweb.cgi/ports/science/InsightToolkit

comment:4 Changed 16 years ago by peter@…

Hi again, does this require any further action on my part? Many thanks!

comment:5 Changed 16 years ago by jmpp@…

Priority: HighNormal

So I see the Portfile in #12413 hasn't been committed. This ticket is for a submission of an updated Portfile with respect to what was submitted there...? If so, this ticket should be closed as invalid and the new Portfile should be added as a new attachment to #12413. What prompted the original poster to open a new ticket?

-jmpp

comment:6 Changed 16 years ago by peter@…

Well, the original ticket hadn't seen any action in quite some time. Given the fact that the original Portfile had not been committed and the software itself has been through a few revisions subsequently, I thought it might be more convenient for the Macports people to have this created as a separate ticket and simply close the old one.

If you'd prefer me to generate a patch against the original Portfile in the original ticket, I can do that. Let me know if you need anything from me to move forward.

Cheers, Peter

comment:7 in reply to:  5 Changed 16 years ago by peter@…

Replying to jmpp@macports.org:

So I see the Portfile in #12413 hasn't been committed. This ticket is for a submission of an updated Portfile with respect to what was submitted there...? If so, this ticket should be closed as invalid and the new Portfile should be added as a new attachment to #12413. What prompted the original poster to open a new ticket?

-jmpp

Hi, sorry, just wanted to follow up. Would you like some further action on my part?

Cheers, Peter

comment:8 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

I closed #12413; we'll handle this in this ticket.

comment:9 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…

comment:10 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

Thanks for pestering us about this again. Sorry we forgot about the original ticket. I committed the portfile now in r34064 with the following changes:

  • removed the line "revision 1" because the initial revision of a portfile should be 0, which is the default
  • removed the line "distfiles ${name}-${version}${extract.suffix}" because that's also already the default

comment:11 Changed 15 years ago by jmroot (Joshua Root)

Type: enhancementsubmission

comment:12 Changed 15 years ago by (none)

Milestone: Port Submissions

Milestone Port Submissions deleted

Note: See TracTickets for help on using tickets.