xterm-229 fails to compile (related to ticket #14000)

[andrelop@…]

As requested on ticket #14000 (which was closed as "worksforme"). I tried again to build xterm after a "port selfupdate" and a "port clean xterm".

Actually, my main target is not xterm but the cssh (clusterssh) port. xterm is only a dependency which is being pulled automatically and getting in the way. The output bellow is the full output of a "port selfupdate", followed by a "port clean xterm" and then a "port install cssh".

Please note that a lot of others dependencies are correctly download, unpacked, patches are applied and everything seems to be getting compiled fine. Actually, even xterm noew seems to be getting download and checksummed correclty.

It only fails to build here. Again, I'm using MacOSX 10.5.1 (Leopard) with all the official Apple patches applied as of some minutes ago. Plese don't be shy to ask me to run everything again with some potential magical command line switch which could enable more detailed debug info.

Here it is :

white:~ andrelop$ sudo port -v selfupdate
Synchronizing local ports tree from rsync://rsync.macports.org/release/ports/
receiving file list ... done

sent 74 bytes  received 295306 bytes  39384.00 bytes/sec
total size is 16418463  speedup is 55.58

MacPorts base version 1.600 installed
receiving file list ... done
./
Mk/
config/
doc/
doc/exampleport/
portmgr/
portmgr/bots/
portmgr/dmg/
portmgr/fedora/
portmgr/freebsd/
portmgr/jobs/
portmgr/packaging/
src/
src/cflib1.0/
src/cregistry/
src/darwintracelib1.0/
src/macports1.0/
src/macports1.0/tests/
src/package1.0/
src/pextlib1.0/
src/pextlib1.0/tests/
src/port/
src/port1.0/
src/port1.0/resources/
src/port1.0/resources/fetch/
src/port1.0/resources/group/
src/port1.0/resources/package/
src/port1.0/tests/
src/portindex/
src/programs/
src/programs/daemondo/
src/registry1.0/
src/registry2.0/
src/registry2.0/tests/
src/tclobjc1.0/
tests/
tests/test/
tests/test/checksums-1/
tests/test/cvs-and-patchsites/
tests/test/dependencies-a/
tests/test/dependencies-b/
tests/test/dependencies-c/
tests/test/envvariables/
tests/test/site-tags/
tests/test/trace/
tests/test/universal/
tests/test/universal-2/
tests/test/xcodeversion/

sent 73 bytes  received 6617 bytes  2676.00 bytes/sec
total size is 3962384  speedup is 592.28

Downloaded MacPorts base version 1.600

The MacPorts installation is not outdated and so was not updated
selfupdate done!
white:~ andrelop$ sudo port clean xterm
--->  Cleaning xterm
white:~ andrelop$ sudo port install cssh
--->  Fetching perl5.8
--->  Attempting to fetch perl-5.8.8.tar.bz2 from http://www.cpan.org/src/5.0/
--->  Verifying checksum(s) for perl5.8
--->  Extracting perl5.8
--->  Applying patches to perl5.8
--->  Configuring perl5.8
--->  Building perl5.8 with target all
--->  Staging perl5.8 into destroot
--->  Installing perl5.8 5.8.8_1
--->  Activating perl5.8 5.8.8_1
--->  Cleaning perl5.8
--->  Fetching p5-term-readkey
--->  Attempting to fetch TermReadKey-2.30.tar.gz from http://ftp.ucr.ac.cr/Unix/CPAN/modules/by-module/Term
--->  Verifying checksum(s) for p5-term-readkey
--->  Extracting p5-term-readkey
--->  Configuring p5-term-readkey
--->  Building p5-term-readkey with target all
--->  Staging p5-term-readkey into destroot
--->  Installing p5-term-readkey 2.30_0
--->  Activating p5-term-readkey 2.30_0
--->  Cleaning p5-term-readkey
--->  Fetching tcl
--->  Attempting to fetch tcl8.5.0-src.tar.gz from http://downloads.sourceforge.net/tcl
--->  Verifying checksum(s) for tcl
--->  Extracting tcl
--->  Configuring tcl
--->  Building tcl with target all
--->  Staging tcl into destroot
--->  Installing tcl 8.5.0_0
--->  Activating tcl 8.5.0_0
--->  Cleaning tcl
--->  Fetching tk
--->  Attempting to fetch tk8.5.0-src.tar.gz from http://downloads.sourceforge.net/tcl
--->  Verifying checksum(s) for tk
--->  Extracting tk
--->  Configuring tk
--->  Building tk with target all
--->  Staging tk into destroot
--->  Installing tk 8.5.0_0
--->  Activating tk 8.5.0_0
--->  Cleaning tk
--->  Fetching p5-tk
--->  Attempting to fetch Tk-804.027.tar.gz from http://ftp.ucr.ac.cr/Unix/CPAN/modules/by-module/Tk
--->  Verifying checksum(s) for p5-tk
--->  Extracting p5-tk
--->  Configuring p5-tk
--->  Building p5-tk with target all
--->  Staging p5-tk into destroot
--->  Installing p5-tk 804.027_0
--->  Activating p5-tk 804.027_0
--->  Cleaning p5-tk
--->  Fetching p5-x11-protocol
--->  Attempting to fetch X11-Protocol-0.53.tar.gz from http://ftp.ucr.ac.cr/Unix/CPAN/modules/by-module/X11
--->  Verifying checksum(s) for p5-x11-protocol
--->  Extracting p5-x11-protocol
--->  Configuring p5-x11-protocol
--->  Building p5-x11-protocol with target all
--->  Staging p5-x11-protocol into destroot
--->  Installing p5-x11-protocol 0.53_0
--->  Activating p5-x11-protocol 0.53_0
--->  Cleaning p5-x11-protocol
--->  Fetching ncursesw
--->  Attempting to fetch ncurses-5.6.tar.gz from http://ftp.gnu.org/gnu/ncurses
--->  Verifying checksum(s) for ncursesw
--->  Extracting ncursesw
--->  Applying patches to ncursesw
--->  Configuring ncursesw
--->  Building ncursesw with target all
--->  Staging ncursesw into destroot
--->  Installing ncursesw 5.6_1
--->  Activating ncursesw 5.6_1
--->  Cleaning ncursesw
--->  Fetching ncurses
--->  Verifying checksum(s) for ncurses
--->  Extracting ncurses
--->  Applying patches to ncurses
--->  Configuring ncurses
--->  Building ncurses with target all
--->  Staging ncurses into destroot
--->  Installing ncurses 5.6_0
--->  Activating ncurses 5.6_0
--->  Cleaning ncurses
--->  Fetching xterm
--->  Attempting to fetch xterm-229.tgz from ftp://invisible-island.net/xterm/
--->  Verifying checksum(s) for xterm
--->  Extracting xterm
--->  Configuring xterm
--->  Building xterm with target all
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_x11_xterm/work/xterm-229" && make all " returned error 2
Command output: /usr/bin/gcc-4.0 -I. -I. -DHAVE_CONFIG_H  -I/usr/X11/include -I/usr/X11/include/freetype2 -I/usr/X11/include -I/usr/X11/include -I/usr/X11/include  -I. -I/usr/X11/include -I/usr/X11/include -I/usr/X11/include/freetype2 -I/usr/X11/include/freetype2/config -I/usr/X11/include -D__i386__ -D__DARWIN__ -DNO_ALLOCA -DCSRG_BASED     -DXFREE86_FT2 -DUTMP  -DOSMAJORVERSION=9 -DOSMINORVERSION=1  -I/usr/X11/include -I/opt/local/include -U_XOPEN_SOURCE -D_XOPEN_SOURCE=500 -DSIGWINCH=28 -DPROJECTROOT='"/usr/X11"' -D__vendorversion__='"Version 6.8.99.903 X.Org"'  -O2  -c ./button.c
/usr/bin/gcc-4.0 -I. -I. -DHAVE_CONFIG_H  -I/usr/X11/include -I/usr/X11/include/freetype2 -I/usr/X11/include -I/usr/X11/include -I/usr/X11/include  -I. -I/usr/X11/include -I/usr/X11/include -I/usr/X11/include/freetype2 -I/usr/X11/include/freetype2/config -I/usr/X11/include -D__i386__ -D__DARWIN__ -DNO_ALLOCA -DCSRG_BASED     -DXFREE86_FT2 -DUTMP  -DOSMAJORVERSION=9 -DOSMINORVERSION=1  -I/usr/X11/include -I/opt/local/include -U_XOPEN_SOURCE -D_XOPEN_SOURCE=500 -DSIGWINCH=28 -DPROJECTROOT='"/usr/X11"' -D__vendorversion__='"Version 6.8.99.903 X.Org"'  -O2  -c ./cachedGCs.c
/usr/bin/gcc-4.0 -I. -I. -DHAVE_CONFIG_H  -I/usr/X11/include -I/usr/X11/include/freetype2 -I/usr/X11/include -I/usr/X11/include -I/usr/X11/include  -I. -I/usr/X11/include -I/usr/X11/include -I/usr/X11/include/freetype2 -I/usr/X11/include/freetype2/config -I/usr/X11/include -D__i386__ -D__DARWIN__ -DNO_ALLOCA -DCSRG_BASED     -DXFREE86_FT2 -DUTMP  -DOSMAJORVERSION=9 -DOSMINORVERSION=1  -I/usr/X11/include -I/opt/local/include -U_XOPEN_SOURCE -D_XOPEN_SOURCE=500 -DSIGWINCH=28 -DPROJECTROOT='"/usr/X11"' -D__vendorversion__='"Version 6.8.99.903 X.Org"'  -O2  -c ./charproc.c
./charproc.c: In function 'in_put':
./charproc.c:3230: error: 'fd_mask' undeclared (first use in this function)
./charproc.c:3230: error: (Each undeclared identifier is reported only once
./charproc.c:3230: error: for each function it appears in.)
make: *** [charproc.o] Error 1

Error: The following dependencies failed to build: xterm
Error: Status 1 encountered during processing.
white:~ andrelop$

[afb@…]

Reproduced on Mac OS X 10.4

[afb@…]

Seems similar to ​http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=33171

Attaching patch for the suggested workaround.

[andrelop@…]

I can confirm that applying the suggested patch fixes the problem for me. Please apply the suggested patch.

[jmroot (Joshua Root)]

Xterm builds fine for me now, on 10.5.2 plus latest xquartz. Could you please check if the X11 update in 10.5.2 fixed this for you?

Even if it did, do we still need this patch for Tiger?

[jonathan@…]

On 10.5.2 with the latest updates and the latest Macports (1.600) still gives me this error until the above patch is applied

(Adding patch-xterm.h to /opt/local/var/macports/sources/rsync.macports.org/release/ports/x11/xterm/files and adding a line to the Portfile to include that patch worked for me.)

[jonathan@…]

Cc Me!

[blb@…]

Patch was needed here, with the latest (237), so applied with a version bump to 237 in r41010.

[(none)]

Milestone Port Bugs deleted