Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#14047 closed update (fixed)

ncbi_tools-20070826

Reported by: mike012012@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: casbon@…
Port:

Description

Update to latest version of software. Added (hopefully) support for livecheck.

Attachments (2)

Portfile-ncbi_tools.diff (3.8 KB) - added by mike012012@… 13 years ago.
ncbi_tools-livecheck.diff (344 bytes) - added by ryandesign (Ryan Schmidt) 13 years ago.
fix livecheck

Download all attachments as: .zip

Change History (10)

Changed 13 years ago by mike012012@…

Attachment: Portfile-ncbi_tools.diff added

comment:1 Changed 13 years ago by ryandesign (Ryan Schmidt)

Milestone: Port EnhancementsPort Updates
Owner: changed from macports-tickets@… to ryandesign@…

comment:2 Changed 13 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

Added your livecheck in r33347. I'm not sure it'll work but we'll see.

Updated the port to version 20070826 in r33351. I also added dist_subdir ${name}/${version} since the distfile name doesn't contain the version. If we did not do this, anyone who still had the old distfile would now get a checksum error when trying to upgrade.

That should take care of #14028 too.

Your patch also undid r23053. I assume you did not mean to do that, so I did not commit that part of your patch.

comment:3 Changed 13 years ago by casbon@…

Resolution: fixed
Status: closedreopened

This is currently broken again as a new release is out. I think the portfile should explicitly list the download url of the version, ie:

master_sites ftp://ftp.ncbi.nlm.nih.gov/toolbox/ncbi_tools/old/20070822/

instead of

master_sites ftp://ftp.ncbi.nlm.nih.gov/toolbox/ncbi_tools/

This will make the port more robust.

comment:4 Changed 13 years ago by casbon@…

Cc: casbon@… added

Cc Me!

comment:5 Changed 13 years ago by ryandesign (Ryan Schmidt)

casbon, I fixed the download location as you suggest in r38755.

The livecheck added in r33347 also doesn't really work great. Attached is a revised livecheck that works better and tells you what new version is available. Mike, I'd like to commit this change if you have no objections.

I'll file new tickets for other issues I have with the ncbi_tools port.

Changed 13 years ago by ryandesign (Ryan Schmidt)

Attachment: ncbi_tools-livecheck.diff added

fix livecheck

comment:6 Changed 13 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: reopenedclosed

Applied my livecheck fix in r39367.

comment:7 Changed 12 years ago by jmroot (Joshua Root)

Type: enhancementupdate

comment:8 Changed 12 years ago by (none)

Milestone: Port Updates

Milestone Port Updates deleted

Note: See TracTickets for help on using tickets.