Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#14228 closed update (fixed)

update xine-lib version to 1.1.9.1 and allow building on intel machines

Reported by: illogical1@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: jmroot (Joshua Root)
Port: xine-lib

Description

xine-lib 1.1.7 all the way up to 1.1.9.1 do not compile cleanly on OS X machines with intel processors. The fault lies first with ffmpeg code included with xine, and then in the deinterlace plugin code. http://lists.macosforge.org/pipermail/macports-users/2007-September/005685.html provides the background for this "enhancement". I believe the non-compilation is either xine, or gcc 4.0, or both's fault.; basically upstream problem.

To get around the issue of xine not being able to compile I've done two things. The first is to specify that we grab an external copy of ffmpeg. This means ffmpeg +postproc is necessary. The second thing I did was disable compilation of the probelmatic parts of the kde_tv deinterlacing code. It's disabled on ALL architectures, intel and ppc, because my familiarity with this stuff is non-existent. But who uses this de-interlacer anyways?

I guess this counts as a bug (kdetv not compiling) and an enhancement (update to 1.1.9.1 and new portfile)

Attachments (4)

patch-kdetv_greedyh.c.diff (851 bytes) - added by illogical1@… 13 years ago.
kdetv_greedy.c patch
patch-kdetv_tomsmocomp.c.diff (908 bytes) - added by illogical1@… 13 years ago.
kdetv_tompscomp.c patch
patch-xine-lib-Portfile (1.0 KB) - added by illogical1@… 13 years ago.
Proposed changes to Portfile
patch-src-post-deinterlace-plugins-Makefile.am (589 bytes) - added by illogical1@… 13 years ago.
fix kdetv_greedyh.c build errors properly

Download all attachments as: .zip

Change History (13)

Changed 13 years ago by illogical1@…

Attachment: patch-kdetv_greedyh.c.diff added

kdetv_greedy.c patch

Changed 13 years ago by illogical1@…

kdetv_tompscomp.c patch

comment:1 Changed 13 years ago by illogical1@…

The proposed changes to the portfile should fix http://trac.macosforge.org/projects/macports/ticket/13492

Changed 13 years ago by illogical1@…

Attachment: patch-xine-lib-Portfile added

Proposed changes to Portfile

comment:2 Changed 13 years ago by jmpp@…

Milestone: Port Updates
Priority: HighNormal
Type: defectenhancement

comment:3 Changed 13 years ago by illogical1@…

A fix got pushed to xine-lib's 1.1 branch so greedy.c won't throw up any errors when 1.1.11 arrives. :-) that just leaves the other issue to worry about.

Changed 13 years ago by illogical1@…

fix kdetv_greedyh.c build errors properly

comment:4 Changed 13 years ago by illogical1@…

comment:5 Changed 12 years ago by jmroot (Joshua Root)

Cc: jmr@… added

I updated xine-lib to 1.1.14 in r38220, and it seems to build fine on x86. Do you think any of these patches may still be needed?

comment:6 Changed 12 years ago by illogical1@…

1.1.14 compiles fine on x86 so the patches aren't necessary anymore. This ticket can be marked as fixed. Universal compilation doesn't work so well, but that's another issue (and ticket).

comment:7 Changed 12 years ago by jmroot (Joshua Root)

Port: xine-lib added
Resolution: fixed
Status: newclosed

comment:8 Changed 12 years ago by jmroot (Joshua Root)

Type: enhancementupdate

comment:9 Changed 12 years ago by (none)

Milestone: Port Updates

Milestone Port Updates deleted

Note: See TracTickets for help on using tickets.