Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#14503 closed update (fixed)

libtool: upgrade to 1.5.26, add patch to avoid -flat_namespace

Reported by: ghosthound Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: libtool MACOSX_DEPLOYMENT_TARGET flat_namespace Cc: boeyms@…
Port:

Description

libtool 1.5.26 plus the attached patch will properly avoid the use of -flat_namespace when 'MACOSX_DEPLOYMENT_TARGET' is not set. The use of flat_namespace on 10.5.2 appears to be harmful (lots of linking problems)

Attachments (2)

patch-libtool.to.1_5_26 (1.1 KB) - added by ghosthound 16 years ago.
Portfile patch to bring to 1.5.26
patch-libtool.m4.diff (1.3 KB) - added by ghosthound 16 years ago.
patchfile for libtool 1.5.26

Download all attachments as: .zip

Change History (8)

Changed 16 years ago by ghosthound

Attachment: patch-libtool.to.1_5_26 added

Portfile patch to bring to 1.5.26

Changed 16 years ago by ghosthound

Attachment: patch-libtool.m4.diff added

patchfile for libtool 1.5.26

comment:1 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: boeyms@… added
Milestone: Port Updates
Owner: changed from boeyms@… to ryandesign@…
Summary: upgrade libtool to 1.5.26, add patch to avoid -flat_namespacelibtool: upgrade to 1.5.26, add patch to avoid -flat_namespace

Upgrading libtool to 1.5.26 is also supposed to fix #13182 on Leopard so I think I'll apply these patches.

comment:2 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

1.5.26 builds fine for me on 10.4 with your patch. I can't test on 10.5 right now. I also don't understand your patch, or your comment "avoid the use of -flat_namespace when MACOSX_DEPLOYMENT_TARGET is not set. The use of flat_namespace on 10.5.2 appears to be harmful". MacPorts always sets MACOSX_DEPLOYMENT_TARGET, so how will avoiding -flat_namespace when MACOSX_DEPLOYMENT_TARGET is not set help anything on Leopard? And is that really all the patch does? It looks to me like it removes a bunch of code from libtool, not all of which deals with -flat_namespace.

comment:3 in reply to:  2 ; Changed 16 years ago by ghosthound

Replying to ryandesign@macports.org:

1.5.26 builds fine for me on 10.4 with your patch. I can't test on 10.5 right now. I also don't understand your patch, or your comment "avoid the use of -flat_namespace when MACOSX_DEPLOYMENT_TARGET is not set. The use of flat_namespace on 10.5.2 appears to be harmful". MacPorts always sets MACOSX_DEPLOYMENT_TARGET, so how will avoiding -flat_namespace when MACOSX_DEPLOYMENT_TARGET is not set help anything on Leopard? And is that really all the patch does? It looks to me like it removes a bunch of code from libtool, not all of which deals with -flat_namespace.

I believe that always setting MACOSX_DEPLOYMENT_TARGET is not yet released. The patch does remove a chunk of code which is bogus (libtool maintainer indicated so) and, IIRC, overrides earlier code that works properly.

comment:4 in reply to:  3 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

Replying to ricci@macports.org:

I believe that always setting MACOSX_DEPLOYMENT_TARGET is not yet released.

Oh yes, you're right, that's not in MacPorts 1.6.0; that's only in trunk. I keep forgetting that.

The patch does remove a chunk of code which is bogus (libtool maintainer indicated so) and, IIRC, overrides earlier code that works properly.

Thanks. If the libtool maintainer says so, that's good enough for me. I committed it in r35661.

comment:5 Changed 15 years ago by jmroot (Joshua Root)

Type: enhancementupdate

comment:6 Changed 15 years ago by (none)

Milestone: Port Updates

Milestone Port Updates deleted

Note: See TracTickets for help on using tickets.