#14804 closed update (fixed)
UPDATE: spidermonkey-1.7.0
| Reported by: | akira@… | Owned by: | akira@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.6.0 |
| Keywords: | javascript spidermonkey | Cc: | markd@… |
| Port: |
Description
Update spidermonkey to 1.7.0.
Attachments (1)
Change History (10)
Changed 16 years ago by akira@…
| Attachment: | spidermonkey.diff added |
|---|
comment:1 Changed 16 years ago by akira@…
| Cc: | markd@… added |
|---|
comment:2 Changed 16 years ago by markd@…
I really don't have the expertise to critique the patch; I only needed it for a dependency at the time I updated the port some time ago so I really know nothing about the app itself. I used existing patches from another project when I modified the port some time ago, openbsd I believe. I think the main problem was that it didn't destroot properly, but wrote straight to $prefix. So I'd say just test it as best you can, make sure it installs and uninstalls ok, and use your own judgement. It would be cool if someone who is interested in it would pick up maintainership too, but that's optional of course.
comment:3 Changed 16 years ago by markd@…
Oops, I see you are listed yourself as maintainer. That's great; thanks for stepping up!
comment:4 Changed 16 years ago by akira@…
| Owner: | changed from macports-tickets@… to akira@… |
|---|---|
| Status: | new → assigned |
Thanks for the information. As you said I could find similar patches on their CVS. Unfortunately, there're no so much commit log for these patches so I couldn't figure out what they're supposed to do.
Anyway, I'll take you advice. Thanks again.
comment:5 Changed 16 years ago by akira@…
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
tested installation and uninstallation works fine. Committed in r35394
comment:6 Changed 16 years ago by markd@…
I wonder if your patches could be contributed upstream to the developers?
comment:7 Changed 16 years ago by akira@…
It would be nice if these patches *fix* some flaws, but as I said earlier, I have no idea what they are doing. but I'm going to investigate them in my spare time.
comment:8 Changed 15 years ago by jmroot (Joshua Root)
| Type: | enhancement → update |
|---|
Mark, Could you please review my patch? I had to re-create some patches to get them applied successfully.