Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#15727 closed defect (fixed)

subversion: ineffectual reinplace of @@DESTROOT@@

Reported by: ryandesign (Ryan Schmidt) Owned by: danielluke (Daniel J. Luke)
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc:


Using the patch from #15514 I noticed that a reinplace statement in the subversion 1.5.0 portfile doesn't do anything:

--->  Fetching subversion
--->  Verifying checksum(s) for subversion
--->  Extracting subversion
--->  Applying patches to subversion
--->  Configuring subversion
Warning: reinplace s|@@DESTROOT@@|/mp/var/macports/build/_Users_rschmidt_macports_dports_devel_subversion/work/destroot|g didn't change anything in /mp/var/macports/build/_Users_rschmidt_macports_dports_devel_subversion/work/subversion-1.5.0/configure
--->  Building subversion with target all svnmucc
--->  Staging subversion into destroot
--->  Installing subversion @1.5.0_0+tools
--->  Activating subversion @1.5.0_0+tools
--->  Cleaning subversion

Maybe the reinplace isn't needed anymore, or maybe it needs to be changed?

Change History (2)

comment:1 Changed 13 years ago by danielluke (Daniel J. Luke)

Resolution: fixed
Status: newclosed

Removed in r37789

(the reinplace did a substitution on a value added by a patch that we no longer use).

comment:2 Changed 12 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.