Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#15860 closed request (fixed)

umit

Reported by: luis.kop@… Owned by: raimue (Rainer Müller)
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: luis.kop@…
Port:

Description

Hi all.

I'm developer of Umit Project and i'm here to request that you test and give suggestions to fix and add our Portfile to our servers, if is it possible.

I hope your feedback.

Thanks for all.

Attachments (3)

patch-setup.diff (606 bytes) - added by luis.kop@… 16 years ago.
Portfile (704 bytes) - added by luis.kop@… 16 years ago.
patch-base.diff (4.5 KB) - added by luis.kop@… 16 years ago.

Download all attachments as: .zip

Change History (12)

Changed 16 years ago by luis.kop@…

Attachment: patch-setup.diff added

comment:1 Changed 16 years ago by luis.kop@…

Cc: luis.kop@… added

Cc Me!

comment:2 Changed 16 years ago by raimue (Rainer Müller)

patch-base.diff hardcodes the prefix /opt/local into the software. It should use ${prefix} instead, so it can be used in different places. I suggest to use a reinplace.

You already added a reinplace for ${prefix} in post-destroot {}, but I think it would be more appropriate to do this in post-patch {}.

comment:3 in reply to:  2 Changed 16 years ago by luis.kop@…

Replying to raimue@macports.org:

patch-base.diff hardcodes the prefix /opt/local into the software. It should use ${prefix} instead, so it can be used in different places. I suggest to use a reinplace.

You already added a reinplace for ${prefix} in post-destroot {}, but I think it would be more appropriate to do this in post-patch {}.

Hi. Thanks for the comment. About the patch-base it's true, it's hardcode. But how hack the file during the installation. Using sed?

About replace post-destroot by post-patch it's not a good idea. It didn't work. Is it mandatory in post-patch?

comment:4 Changed 16 years ago by raimue (Rainer Müller)

Use this in the patch file:

CONFIG_DIR = "__PREFIX__/share/umit/config"
...

And use this post-patch:

post-patch {
    reinplace "s|__PREFIX__|${prefix}|g" ${worksrcpath}/umitCore/BasePaths.py
}

I don't think you need another reinplace in post-destroot.

Changed 16 years ago by luis.kop@…

Attachment: Portfile added

Changed 16 years ago by luis.kop@…

Attachment: patch-base.diff added

comment:5 Changed 16 years ago by luis.kop@…

yeah. It's true.

You're right. I copy this from other Portfile and I didn't understand. Now I understand and I fix it. The files are commited. What do you think about that? Is it ok, now? :)

comment:6 Changed 16 years ago by raimue (Rainer Müller)

Owner: changed from macports-tickets@… to raimue@…
Status: newassigned

comment:7 Changed 16 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: assignedclosed

Committed in r38112.

comment:8 Changed 15 years ago by jmroot (Joshua Root)

Type: enhancementrequest

comment:9 Changed 15 years ago by (none)

Milestone: Port Requests

Milestone Port Requests deleted

Note: See TracTickets for help on using tickets.