#16361 closed enhancement (fixed)
wireshark-1.0.2 Portfile enhancement request
| Reported by: | victor@… | Owned by: | ghosthound |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.6.0 |
| Keywords: | wireshark | Cc: | victor@… |
| Port: |
Description
Eric, can you please commit this...
port:portaudio may to be added to the Portfile library dependencies of port wireshark in order to enable the rtp_player in wireshark builds. Diff attached.
Attachments (1)
Change History (7)
Changed 16 years ago by victor@…
| Attachment: | Portfile-wireshark.diff added |
|---|
comment:2 Changed 16 years ago by ghosthound
Victor-
Please do not commit changes to ports that are not marked with 'nomaintainer' or 'openmaintainer' (unless, of course, the 72 hour timeout has passed). In particular, I'm currently working on and testing the addition of the rtp support requested, and I see you've gone and committed the patch you attached to this ticket. I also see that this patch is incomplete (doesn't include the configure args to add portaudio) and you've added it to the default install of wireshark without providing a variant for people to decide if they want to include rtp support.
-eric
comment:3 Changed 16 years ago by ghosthound
| Owner: | changed from opendarwin.org@… to ricci@… |
|---|---|
| Status: | new → assigned |
comment:4 Changed 16 years ago by ghosthound
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:5 Changed 16 years ago by victor@…
Eric -
Sorry I didn't wait. Honestly, I did check to see who last updated the port and noted it was ricci@… and not the listed maintainer opendarwin.org@…. I assumed these were different people because of the different addresses--and that the maintainer was not responding and therefore this other person had updated--obviously they're the same person, you.
At any rate I think you're making a good suggestion that it be configurable, but FYI portaudio is checked in configure by default and rtp_player is enabled by default in the port already, so making it configurable is always a good thing.
I also noted your addition of the other configurable options omitted descriptions, so that's the only reason for my 2nd commit and I had done so before receiving your (this) message I'm responding to now.
Trust me, I don't want to take over the wireshark port ;) Please have at it!
I was just annoyed it didn't include the portaudio dependency when it was configured and built by default by wireshark and since portaudio was already in the port tree. So thanks for including and sorry for the crossover, it was purely a misunderstanding due to the different e-mail addresses.
Thanks,
Victor
comment:6 Changed 15 years ago by (none)
| Milestone: | Port Enhancements |
|---|
Milestone Port Enhancements deleted
Diff for wireshark Portfile