Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#17062 closed defect (fixed)

gimp2: +quartz variant

Reported by: pguyot (Paul Guyot) Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc:
Port: gimp2

Description

gimp2 almost compiles with gtk2+quartz and friends. It just needs a small tweak, and the attached patch just does this (plus adds some logic inspired from the gtk2/pango logic to mark it as +quartz or +x11 depending on what version of gtk2 is installed and activated).

Attachments (2)

gimp2_quartz.diff (1.4 KB) - added by pguyot (Paul Guyot) 15 years ago.
patch-gimp2-Portfile-quartz.diff (1.9 KB) - added by dbevans (David B. Evans) 15 years ago.
Modified patch for Portfile

Download all attachments as: .zip

Change History (9)

Changed 15 years ago by pguyot (Paul Guyot)

Attachment: gimp2_quartz.diff added

comment:1 Changed 15 years ago by dbevans (David B. Evans)

Owner: changed from db.evans@… to devans@…
Status: newassigned

Thanks for this, I'll give it a try. I still haven't been able to get gtk2 +no_x11 to compile on Tiger which is all I have available to me so I assume you are using Leopard? By the way, I'm trying to stay will +no_x11 instead of +quartz as that is the way most of the other ports are going.

comment:2 Changed 15 years ago by jmroot (Joshua Root)

That exec grep is going to throw an error when it doesn't find GDK_WINDOWING_QUARTZ, so you'll need to catch it. The same applies to gnome-desktop, BTW.

comment:3 Changed 15 years ago by pguyot (Paul Guyot)

@devans: yes, this is on 10.5 (just upgraded a few days ago). @jmr: oops. Thanks for spotting this. I fixed the logic for gnome-desktop in r41405 (and for eel in r41406). The same fix should be applied to this patch.

comment:4 Changed 15 years ago by dbevans (David B. Evans)

Here is the modified patch to allow building gimp2 +quartz +no_x11. Tested now in both with and without +quartz +no_x11 on Tiger using patch from #16978 (not yet committed) to allow building of gtk +no_x11 on Tiger. If you'll confirm this works on Leopard will commit it. Thanks for your help.

Changed 15 years ago by dbevans (David B. Evans)

Modified patch for Portfile

comment:5 Changed 15 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: assignedclosed

Committed modified patch in r41518. Thanks.

comment:6 Changed 15 years ago by pguyot (Paul Guyot)

The +quartz variant works as expected on 10.5.5/x86.

comment:7 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.