Opened 12 years ago

Closed 10 years ago

#17103 closed defect (invalid)

Mplayer osd wrong configure option

Reported by: anddam (Andrea D'Amore) Owned by: ecronin (Eric Cronin)
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: mplayer configure Cc:
Port: MPlayer

Description

The "osd" variant has

--enable-freetype

in configure options but this is deprecated. The configure script should not be forced to enable it or it won't stop on freetype check failure thus breaking the following build.

This could be related to #15624 too.

Change History (7)

comment:1 Changed 12 years ago by ecronin (Eric Cronin)

Status: newassigned

Low on time right now but I'll take a look as soon as I can. Where is --enable-freetype deprecated? The problem with not explicitly using --enable or --disable with features is that if the library happens to be detected by configure you end up with an unregistered dependency. If freetype is not needed at all for ttf OSD than that's easy enough to fix.

comment:2 Changed 12 years ago by ecronin (Eric Cronin)

Milestone: Port EnhancementsPort Bugs
Type: enhancementdefect

comment:3 Changed 12 years ago by andrea.damore@…

My experience: I specified +osd variant but got a build without osd support. This message suggests not to use --enable-freetype and the author of that message explictly told me:

--enable-freetype doesn't make configure fail when it can't find it (like on autotools), it makes it ignore the test and try to compile it

So far I think there have been a problem with the port dependency on freetype but unluckily I dont' have build logs as obviously at the time I didn't knew I was going to have problems. I then built mplayer again without --enable-freetype and osd worked fine.

To answer your question: freetype is needed dependency for the osd variant but, from what I read, it should just not be in configure option.

comment:4 Changed 12 years ago by andrea.damore@…

Summary: MPlayer fix for configureFix configure option

comment:5 Changed 12 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

comment:6 Changed 12 years ago by anddam (Andrea D'Amore)

Summary: Fix configure optionMplayer osd wrong configure option

comment:7 Changed 10 years ago by anddam (Andrea D'Amore)

Resolution: invalid
Status: assignedclosed

mplayer-devel builds fine, the original problem can't be reproduced and there are no log files. I'm closing the ticket.

Note: See TracTickets for help on using tickets.