Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#17114 closed submission (fixed)

New Port: HAProxy

Reported by: sam@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: w@…, sam@…
Port: haproxy

Description

I like using HA Proxy and decided to write my first portfile for it.

However, I need some help on the portfile.

I've tried building it two ways:

  1. make -f Makefile.osx
  2. make TARGET=osx

Here's the build log from make -f Makefile.osx http://pastie.org/309129

And here's the build log from make TARGET=osx http://pastie.org/309138

The two builds do not output the same text when the user types haproxy -v Build #1

sam@sam.local(master)> haproxy -v
HA-Proxy version  
Copyright 2000-2008 Willy Tarreau <w@1wt.eu>

Build #2

sam@sam.local(master)> haproxy -v
HA-Proxy version 1.3.15.6 2008/11/04
Copyright 2000-2008 Willy Tarreau <w@1wt.eu>

By looking at the build log I can see that build #2 sets the correct date. -DCONFIG_HAPROXY_VERSION=\"1.3.15.6\" -DCONFIG_HAPROXY_DATE=\"2008/11/04\"

Would I need to make a patch to Makefile.osx, or possibly use the macports reinplace function to get the correct output?

Any guidance would be much appreciated, and thank you Willy for some great software!

Attachments (2)

Portfile (1.4 KB) - added by sam@… 11 years ago.
Portfile.2 (1.4 KB) - added by sam@… 11 years ago.
updated portfile with cpu optimizations

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by sam@…

Attachment: Portfile added

comment:1 Changed 11 years ago by sam@…

Cc: sam@… added

Cc Me!

comment:2 Changed 11 years ago by blb@…

Keywords: haproxy removed
Port: haproxy added

What is the problem with using TARGET=osx, looking at the main Makefile, that seems to be the supported method for building haproxy? Also, would you mind being the maintainer for the port? Finally, you can add a platform i386 section and set CPU=i686 to get the optimizations, like so:

platform i386 {
   build.target-append   CPU=i686
}

comment:3 Changed 11 years ago by sam@…

Sure, I'll be the maintainer. I'll go with the TARGET=osx instructions, and I also added the cpu optimization for i386.

Changed 11 years ago by sam@…

Attachment: Portfile.2 added

updated portfile with cpu optimizations

comment:4 Changed 11 years ago by blb@…

Resolution: fixed
Status: newclosed

Added in r41609, thanks. Note that I removed the distname entry since what you listed is actually the default (${name}-${version}), and put your email as maintainer (in the obfuscated form we use).

comment:5 Changed 10 years ago by jmroot (Joshua Root)

Type: enhancementsubmission

comment:6 Changed 10 years ago by (none)

Milestone: Port Submissions

Milestone Port Submissions deleted

Note: See TracTickets for help on using tickets.