Opened 12 years ago

Closed 11 years ago

#17606 closed defect (fixed)

Default variant of vim doesn't build due to X11 dependency

Reported by: pgijnxn02@… Owned by: raimue (Rainer Müller)
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: Xsetlocale X11 Cc: messi@…, blb@…
Port: vim

Description (last modified by ryandesign (Ryan Schmidt))

I failed to build vim with no variants.

The configure log shows --enable-gui=no --without-x but the linker fails with this message:

/usr/libexec/gcc/powerpc-apple-darwin8/4.0.1/ld: Undefined symbols:
 __Xsetlocale

Adding -lX11 to the linker command line enabled it to build and I was able to continue.

Attachments (2)

config.log (196.9 KB) - added by pgijnxn02@… 12 years ago.
patch-src_auto_configure.diff (484 bytes) - added by blb@… 12 years ago.
diff to src/auto/configure

Download all attachments as: .zip

Change History (14)

Changed 12 years ago by pgijnxn02@…

Attachment: config.log added

comment:1 in reply to:  description Changed 12 years ago by pgijnxn02@…

My setup:

Macports Trunk vim @7.2.065_0 OS X Tiger 10.4.11 Mac Mini PPC

comment:2 Changed 12 years ago by jmroot (Joshua Root)

Owner: changed from macports-tickets@… to raimue@…

comment:3 Changed 12 years ago by mf2k (Frank Schima)

Keywords: vim removed
Port: vim added; editors/vim removed

comment:4 Changed 12 years ago by ryandesign (Ryan Schmidt)

Description: modified (diff)

comment:5 Changed 12 years ago by messi@…

This problem comes with --enable-multibyte. Replacing it with --disable-multibyte also fixes the problem. No libX11 needed.

Vim feature +multi_byte is activated again if i.e. variant +huge is specified.

comment:6 in reply to:  5 ; Changed 12 years ago by raimue (Rainer Müller)

Replying to messi@…:

This problem comes with --enable-multibyte. Replacing it with --disable-multibyte also fixes the problem. No libX11 needed.

Thanks for tracking this down. Strange enough that multibyte support needs X. How should I change this? Should I move multibyte in its own variant, as it was until some time ago?

comment:7 in reply to:  6 Changed 12 years ago by messi@…

Replying to raimue@…:

Replying to messi@…:

This problem comes with --enable-multibyte. Replacing it with --disable-multibyte also fixes the problem. No libX11 needed.

Thanks for tracking this down. Strange enough that multibyte support needs X. How should I change this? Should I move multibyte in its own variant, as it was until some time ago?

Good question. I think you should take a look at ./src/auto/configure:15458 first. When you allow --enable-multibyte to be set (globally or by variant) you should make sure that $x_includes is empty if X11 is not installed. Otherwise configure tries to link the check program against libX11.

comment:8 Changed 12 years ago by messi@…

Cc: messi@… added

Cc Me!

Changed 12 years ago by blb@…

diff to src/auto/configure

comment:9 Changed 12 years ago by blb@…

Cc: blb@… added

Adding this patch to the port should get it to work properly; a similar one against src/configure.in should probably be sent upstream.

comment:10 Changed 12 years ago by raimue (Rainer Müller)

Status: newassigned

I applied the patch to both vim and vim-app in r45697. I will look into sending a patch against configure.in to upstream.

comment:11 Changed 12 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

comment:12 Changed 11 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: assignedclosed

The patch has been accepted upstream as 7.2.159.

Note: See TracTickets for help on using tickets.