Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#17623 closed submission (fixed)

upx 3.03 new port

Reported by: 0xced (Cédric Luthi) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Port: upx

Description

Hello,
Here is the UPX port I just created.

Attachments (4)

Portfile (1.8 KB) - added by 0xced (Cédric Luthi) 12 years ago.
Portfile with lzma variant
Portfile.diff (2.4 KB) - added by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) 12 years ago.
Portfile.2.diff (493 bytes) - added by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) 12 years ago.
Portfile2.diff (491 bytes) - added by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) 12 years ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 12 years ago by mf2k (Frank Schima)

Keywords: upx removed
Port: upx added

Changed 12 years ago by 0xced (Cédric Luthi)

Attachment: Portfile added

Portfile with lzma variant

Changed 12 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Attachment: Portfile.diff added

comment:2 Changed 12 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Resolution: fixed
Status: newclosed

I committed the port in r43672.
Thanks for the submission.
I made a few changes, which I attached here.

comment:3 Changed 12 years ago by 0xced (Cédric Luthi)

Thanks for committing. I just have a question: does the line

depends_build    path:bin/perl:perl5

implies that the perl5 port will be installed ?

If yes, isn't it a bit overkill ? pod2XXX are in /usr/bin (at least on Leopard, can't say on Tiger).

comment:4 in reply to:  3 ; Changed 12 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Replying to cedric.luthi@…:

implies that the perl5 port will be installed ?

Yes, perl5 must be installed during the build phase.

If yes, isn't it a bit overkill ? pod2XXX are in /usr/bin (at least on Leopard, can't say on Tiger).

In this particular case, the system tools would almost certainly suffice, but MacPorts has a
pretty strict policy of using using its own tools and libraries.
There are only a few exceptions (X11 for example).

comment:5 Changed 12 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Cc: mcalhoun@… added

Cc Me!

comment:6 in reply to:  4 Changed 12 years ago by 0xced (Cédric Luthi)

In this particular case, the system tools would almost certainly suffice, but MacPorts has a
pretty strict policy of using using its own tools and libraries.
There are only a few exceptions (X11 for example).

The policy you are referring to is about libraries, not about tools for what I understood. For libraries, I totally agree the MacPorts own libraries policy. But in this particular case, these are tools (perl scripts specifically) that are installed on the system, and perl is itself installed on the system too. I have personally installed perl with MacPorts, but I think about other people who just want to install upx thinking it should take about one minute or two and they must wait one hour because perl is installed.
Could someone on Tiger and someone on Pather confirm that the pod2man, pod2text and pod2html are installed on these systems so that we could remove this annoying dependency ?

Changed 12 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Attachment: Portfile.2.diff added

Changed 12 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Attachment: Portfile2.diff added

comment:7 Changed 12 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

I changed the perl dependencies in Portfile2.diff.
perl5 will no longer be installed if the programs are installed.
If this is satisfactory, I will commit the patch.

comment:8 Changed 12 years ago by 0xced (Cédric Luthi)

The MacPorts Guide says:
File dependencies are specifed in the form: <type>:<filename>:<port>. <filename> is relative to ${prefix}.
I understand that this mean /usr/bin won't be searched for <filename>, only /opt/local/bin. Am I correct or it the MacPorts Guide not accurate ?
If /usr/bin is not searched for pod2(man|text|html), then the patch is useless and perl will be installed anyway. If /usr/bin is searched for pod2(man|text|html), then please go ahead with the patch. :-)

comment:9 Changed 12 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

I made the change in r43681.

The dependencies section of the MacPorts needs improvement.
bin:pod2(...):perl5 should look in /usr/bin for the binary files.

The source of the misstatment in the Guide is the fact that:
path:bin/perl:perl5 will look only for ${prefix}/bin/perl to satisfy the dependency.

comment:10 in reply to:  9 Changed 12 years ago by 0xced (Cédric Luthi)

Replying to mcalhoun@…:

bin:pod2(...):perl5 should look in /usr/bin for the binary files.

OK, thanks for the clarification. Maybe the guide should be rephrased to something like this ?

File dependencies are specifed in the form: <type>:<filename>:<port>. <filename> is relative to ${prefix}, except when <type> is bin. In this case, <filename> is searched in the PATH environment variable.

comment:11 Changed 12 years ago by 0xced (Cédric Luthi)

Oops, it seems you did a copy-paste error, there is two times pod2html instead of pod2html and pod2man. This is probably not a problem as pod2html and pod2man are most probably installed together, but you may want to fix it anyway ;-)

comment:12 in reply to:  11 Changed 12 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Replying to cedric.luthi@…:

Oops, it seems you did a copy-paste error, there is two times pod2html instead of pod2html and pod2man.

Thanks for the catch.
Fixed in r43684.
I'll get this right one of these days (quite a bit of effort on a closed ticket).

comment:13 Changed 12 years ago by 0xced (Cédric Luthi)

Thanks for your efforts. I hope it's definitely closed now ;-)

comment:14 Changed 12 years ago by jmroot (Joshua Root)

Type: enhancementsubmission

comment:15 Changed 12 years ago by (none)

Milestone: Port Submissions

Milestone Port Submissions deleted

Note: See TracTickets for help on using tickets.