Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#17635 closed defect (fixed)

upgrade_sources_conf_default.tcl script needs svn with file:/// sources via svn

Reported by: blb@… Owned by: blb@…
Priority: Normal Milestone: MacPorts 1.7.1
Component: base Version: 1.7.0
Keywords: Cc:
Port:

Description

Minor issue, but upgrade_sources_conf_default.tcl (run with 'make install' and postflight) assumes an svn is available if sources.conf uses a file:/// source which is itself a subversion checkout. Odds are quite small that someone will have a subversion checkout without subversion, but upgrade_sources_conf_default.tcl should still be better than

couldn't execute "svn": no such file or directory
    while executing
"open "|svn info ${filepath}" r"
    ("while" body line 12)
    invoked from within
"while {[gets $sourcesConfChannel line] >= 0} {
   set addDefault false
   if {!$defaultSeen && ![regexp {^\s*#|^$} $line]} {
      if {[regexp {^([\w-..."
    (file "src/upgrade_sources_conf_default.tcl" line 34)

Change History (3)

comment:1 Changed 15 years ago by blb@…

A variation of this was posted to macports-users.

comment:2 Changed 15 years ago by blb@…

Resolution: fixed
Status: newclosed
Version: 1.6.01.7.0

Updated in r46983, by ignoring an svn-based repo when svn isn't found, it will cause the puts at the end to point out how to manually update sources.conf.

comment:3 Changed 15 years ago by blb@…

And since I somehow forgot to merge to 1.7 branch, that was done in r47619.

Note: See TracTickets for help on using tickets.