Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#17892 closed defect (fixed)

tuntaposx updates

Reported by: michaelld (Michael Dickens) Owned by: febeling@…
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: tuntaposx Cc:
Port: tuntaposx

Description

tuntaposx does not compile if 'gcc' or 'g++' in the user's PATH are not those provided by Apple. Put another way: tuntaposx requires the use of Apple's GCC and G++ to successfully compile. I've included 2 patch files to change the Makefiles to use Apple's GCC (/usr/bin/gcc) and G++ (/usr/bin/g++) explicitly. I've also included a darwin 9 specific change to use the 10.5U SDK (the Makefiles use the 10.4U SDK by default). The attached archive contains both the Portfile patch as well as the new files/patches.

Attachments (3)

tuntaposx_files.tar.bz2 (1.2 KB) - added by michaelld (Michael Dickens) 15 years ago.
Updated files for tuntaposx port
tuntaposx.tar.bz2 (1.8 KB) - added by michaelld (Michael Dickens) 15 years ago.
Updated files for tuntaposx port, try # 2
tuntaposx_Portfile.diff (1.8 KB) - added by michaelld (Michael Dickens) 15 years ago.
'diff -u' of the tuntaposx Portfile, matching the previous tarball

Download all attachments as: .zip

Change History (10)

Changed 15 years ago by michaelld (Michael Dickens)

Attachment: tuntaposx_files.tar.bz2 added

Updated files for tuntaposx port

comment:1 Changed 15 years ago by raimue (Rainer Müller)

Owner: changed from macports-tickets@… to febeling@…

comment:2 Changed 15 years ago by jmroot (Joshua Root)

In fact, ${configure.cc} and ${configure.cxx} should be used instead of hardcoding anything.

comment:3 Changed 15 years ago by michaelld (Michael Dickens)

I've updated the Portfile and patches to be more generic, by setting the build environment (build.env) CC and CXX variables to be Apple's compiler-variants in /usr/bin, and removing those explicit dependencies from the Makefiles. I also changed the SDK version to use the build environment variable MACOSX_DEPLOYMENT_TARGET instead of having a special patch for Darwin 9. This time, I'm attaching the whole Portfile and related files instead of patches; just easier with the number of changes.

Changed 15 years ago by michaelld (Michael Dickens)

Attachment: tuntaposx.tar.bz2 added

Updated files for tuntaposx port, try # 2

comment:4 Changed 15 years ago by febeling@…

First: thanks for looking into this! It would be easier for if you'd provide a patch, because otherwise I have to read it line by line. I'm really short on time right now and in the middle of moving appartments, so that might speed things up.

Another option to speed things is to talk another comitter into testing and checking in, since the port is declared openmaintainer, which means it is ok with me.

Also, we should handle differnt problems separately, so this update to another SDK should go as a second change I guess. (What do we gain by that?)

comment:5 Changed 15 years ago by michaelld (Michael Dickens)

OK. I'm attaching just the 'diff -u' of the Portfile. Changing the SDK is done there as a 'reinplace', and hence can be easily removed or changed. Using the 10.5u SDK means that the resulting code will execute only on a computer running 10.5 or newer; using 10.4u SDK means that the resulting code will execute only on a computer running 10.4 or newer. There are sometimes features in a newer SDK which make it attractive to use; I do not know if this is the case for tuntaposx, but it certainly can't hurt.

Changed 15 years ago by michaelld (Michael Dickens)

Attachment: tuntaposx_Portfile.diff added

'diff -u' of the tuntaposx Portfile, matching the previous tarball

comment:6 Changed 15 years ago by febeling@…

Resolution: fixed
Status: newclosed

r45156. Thanks mlk!

comment:7 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.