Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#18193 closed enhancement (fixed)

mpd-0.13.2 default library dependencies per upstream

Reported by: Ryan.Stonecipher.Fisher@… Owned by: milosh@…
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: mpd flac aac Cc:
Port: mpd

Description

The current Portfile for mpd explicitly disables FLAC and AAC, two formats enabled by default by mpd. This patch adds default dependencies for mpd (port:flac, port:libfaad2), removes non-default variants (+flac, +aac), and adds variants for optional dependencies (+mod and +modplug).

Attachments (1)

Portfile-mpd.diff (1.5 KB) - added by Ryan.Stonecipher.Fisher@… 15 years ago.

Download all attachments as: .zip

Change History (6)

Changed 15 years ago by Ryan.Stonecipher.Fisher@…

Attachment: Portfile-mpd.diff added

comment:1 Changed 15 years ago by blb@…

Owner: changed from macports-tickets@… to milosh@…

comment:2 Changed 15 years ago by milosh@…

Status: newassigned

I would prefer keeping the variants for flac and aac so that users may choose not to compile them. Adding them as default_variants should be a viable method, don't you think?

Are mod and modplug mutually exclusive? They seem to both provide playing of mod files.

Ryan, would you be OK to be added to the maintainers of mpd? to become the maintainer?

comment:3 in reply to:  2 Changed 15 years ago by Ryan.Stonecipher.Fisher@…

Replying to milosh@…

Are mod and modplug mutually exclusive? They seem to both provide playing of mod files.

After some discussion with #mpd on Freenode I have learned that: (1) both support: amf, dsm, far, it, med, mod, mtm, s3m, stm, ult, xm (2) libmikmod supports: gdm, imf, and stx (3) libmodplug supports: 669, ams, dbm, dfm, mdl, mt2, okt, umx, uni It would seem there is a case for installing both.

comment:4 Changed 15 years ago by milosh@…

Resolution: fixed
Status: assignedclosed

Committed the new variants in r46022.

flac is now built by default + new maintainer in r46023.

Thanks

comment:5 Changed 15 years ago by (none)

Milestone: Port Enhancements

Milestone Port Enhancements deleted

Note: See TracTickets for help on using tickets.