xorg-libX11 1.1.99.2_1 upgrade fails on 10.4

[horst@…]

xorg-libX11 1.1.99.2_1 fails on OSX 10.4 (Tiger) with Xcode 2.5.

xorg-libX11                    1.1.5_1 < 1.1.99.2_1

--->  Fetching xorg-libX11
--->  Verifying checksum(s) for xorg-libX11
--->  Extracting xorg-libX11
--->  Configuring xorg-libX11
--->  Building xorg-libX11
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_x11_xorg-libX11/work/libX11-1.1.99.2" && make all " returned error 2
Command output: mv -f .deps/imLcSIc.Tpo .deps/imLcSIc.Plo
../../../doltcompile /usr/bin/gcc-4.0 -DHAVE_CONFIG_H -I. -I../../../src -I../../../include/X11   -I/opt/local/include -I../../../include -I../../../include/X11 -I../../../include -I../../../include/X11 -I../../../src/xcms -I../../../src/xkb -I../../../src/xlibi18n -Wall -Wpointer-arith -Wstrict-prototypes 	-Wmissing-prototypes -Wmissing-declarations 	-Wnested-externs -fno-strict-aliasing -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/opt/local/include    -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -DHASXDMAUTH -D_BSD_SOURCE -DXIM_t -DTRANS_CLIENT  -O2 -MT imRmAttr.lo -MD -MP -MF .deps/imRmAttr.Tpo -c -o imRmAttr.lo imRmAttr.c
mv -f .deps/imRmAttr.Tpo .deps/imRmAttr.Plo
../../../doltcompile /usr/bin/gcc-4.0 -DHAVE_CONFIG_H -I. -I../../../src -I../../../include/X11   -I/opt/local/include -I../../../include -I../../../include/X11 -I../../../include -I../../../include/X11 -I../../../src/xcms -I../../../src/xkb -I../../../src/xlibi18n -Wall -Wpointer-arith -Wstrict-prototypes 	-Wmissing-prototypes -Wmissing-declarations 	-Wnested-externs -fno-strict-aliasing -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/opt/local/include    -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -DHASXDMAUTH -D_BSD_SOURCE -DXIM_t -DTRANS_CLIENT  -O2 -MT imRm.lo -MD -MP -MF .deps/imRm.Tpo -c -o imRm.lo imRm.c
imRm.c: In function '_XimDefaultIMValues':
imRm.c:413: warning: assignment discards qualifiers from pointer target type
imRm.c: In function '_XimDefaultICValues':
imRm.c:450: warning: assignment discards qualifiers from pointer target type
mv -f .deps/imRm.Tpo .deps/imRm.Plo
../../../doltcompile /usr/bin/gcc-4.0 -DHAVE_CONFIG_H -I. -I../../../src -I../../../include/X11   -I/opt/local/include -I../../../include -I../../../include/X11 -I../../../include -I../../../include/X11 -I../../../src/xcms -I../../../src/xkb -I../../../src/xlibi18n -Wall -Wpointer-arith -Wstrict-prototypes 	-Wmissing-prototypes -Wmissing-declarations 	-Wnested-externs -fno-strict-aliasing -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/opt/local/include    -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -DHASXDMAUTH -D_BSD_SOURCE -DXIM_t -DTRANS_CLIENT  -O2 -MT imThaiFlt.lo -MD -MP -MF .deps/imThaiFlt.Tpo -c -o imThaiFlt.lo imThaiFlt.c
mv -f .deps/imThaiFlt.Tpo .deps/imThaiFlt.Plo
../../../doltcompile /usr/bin/gcc-4.0 -DHAVE_CONFIG_H -I. -I../../../src -I../../../include/X11   -I/opt/local/include -I../../../include -I../../../include/X11 -I../../../include -I../../../include/X11 -I../../../src/xcms -I../../../src/xkb -I../../../src/xlibi18n -Wall -Wpointer-arith -Wstrict-prototypes 	-Wmissing-prototypes -Wmissing-declarations 	-Wnested-externs -fno-strict-aliasing -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/opt/local/include    -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -DHASXDMAUTH -D_BSD_SOURCE -DXIM_t -DTRANS_CLIENT  -O2 -MT imThaiIc.lo -MD -MP -MF .deps/imThaiIc.Tpo -c -o imThaiIc.lo imThaiIc.c
mv -f .deps/imThaiIc.Tpo .deps/imThaiIc.Plo
../../../doltcompile /usr/bin/gcc-4.0 -DHAVE_CONFIG_H -I. -I../../../src -I../../../include/X11   -I/opt/local/include -I../../../include -I../../../include/X11 -I../../../include -I../../../include/X11 -I../../../src/xcms -I../../../src/xkb -I../../../src/xlibi18n -Wall -Wpointer-arith -Wstrict-prototypes 	-Wmissing-prototypes -Wmissing-declarations 	-Wnested-externs -fno-strict-aliasing -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/opt/local/include    -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -DHASXDMAUTH -D_BSD_SOURCE -DXIM_t -DTRANS_CLIENT  -O2 -MT imThaiIm.lo -MD -MP -MF .deps/imThaiIm.Tpo -c -o imThaiIm.lo imThaiIm.c
mv -f .deps/imThaiIm.Tpo .deps/imThaiIm.Plo
../../../doltcompile /usr/bin/gcc-4.0 -DHAVE_CONFIG_H -I. -I../../../src -I../../../include/X11   -I/opt/local/include -I../../../include -I../../../include/X11 -I../../../include -I../../../include/X11 -I../../../src/xcms -I../../../src/xkb -I../../../src/xlibi18n -Wall -Wpointer-arith -Wstrict-prototypes 	-Wmissing-prototypes -Wmissing-declarations 	-Wnested-externs -fno-strict-aliasing -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/opt/local/include    -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -DHASXDMAUTH -D_BSD_SOURCE -DXIM_t -DTRANS_CLIENT  -O2 -MT imTrans.lo -MD -MP -MF .deps/imTrans.Tpo -c -o imTrans.lo imTrans.c
mv -f .deps/imTrans.Tpo .deps/imTrans.Plo
../../../doltcompile /usr/bin/gcc-4.0 -DHAVE_CONFIG_H -I. -I../../../src -I../../../include/X11   -I/opt/local/include -I../../../include -I../../../include/X11 -I../../../include -I../../../include/X11 -I../../../src/xcms -I../../../src/xkb -I../../../src/xlibi18n -Wall -Wpointer-arith -Wstrict-prototypes 	-Wmissing-prototypes -Wmissing-declarations 	-Wnested-externs -fno-strict-aliasing -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/opt/local/include    -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -DHASXDMAUTH -D_BSD_SOURCE -DXIM_t -DTRANS_CLIENT  -O2 -MT imTransR.lo -MD -MP -MF .deps/imTransR.Tpo -c -o imTransR.lo imTransR.c
mv -f .deps/imTransR.Tpo .deps/imTransR.Plo
../../../doltcompile /usr/bin/gcc-4.0 -DHAVE_CONFIG_H -I. -I../../../src -I../../../include/X11   -I/opt/local/include -I../../../include -I../../../include/X11 -I../../../include -I../../../include/X11 -I../../../src/xcms -I../../../src/xkb -I../../../src/xlibi18n -Wall -Wpointer-arith -Wstrict-prototypes 	-Wmissing-prototypes -Wmissing-declarations 	-Wnested-externs -fno-strict-aliasing -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/opt/local/include    -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -DHASXDMAUTH -D_BSD_SOURCE -DXIM_t -DTRANS_CLIENT  -O2 -MT imTrX.lo -MD -MP -MF .deps/imTrX.Tpo -c -o imTrX.lo imTrX.c
imTrX.c: In function '_XimXRead':
imTrX.c:441: warning: 'len' may be used uninitialized in this function
mv -f .deps/imTrX.Tpo .deps/imTrX.Plo
../../../doltlibtool --tag=CC   --mode=link /usr/bin/gcc-4.0 -I../../../include -I../../../include/X11 -I../../../include -I../../../include/X11 -I../../../src/xcms -I../../../src/xkb -I../../../src/xlibi18n -Wall -Wpointer-arith -Wstrict-prototypes 	-Wmissing-prototypes -Wmissing-declarations 	-Wnested-externs -fno-strict-aliasing -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/opt/local/include    -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -I/opt/local/include   -DHASXDMAUTH -D_BSD_SOURCE -DXIM_t -DTRANS_CLIENT  -O2  -L/opt/local/lib -o libximcp.la  imCallbk.lo imDefFlt.lo imDefIc.lo imDefIm.lo imDefLkup.lo imDispch.lo imEvToWire.lo imExten.lo imImSw.lo imInsClbk.lo imInt.lo imLcFlt.lo imLcGIc.lo imLcIc.lo imLcIm.lo imLcLkup.lo imLcPrs.lo imLcSIc.lo imRmAttr.lo imRm.lo imThaiFlt.lo imThaiIc.lo imThaiIm.lo imTrans.lo imTransR.lo imTrX.lo  
../../../doltlibtool: line 11: syntax error near unexpected token `"$arg"'
../../../doltlibtool: line 11: `        *) args+=("$arg")'
make[3]: *** [libximcp.la] Error 2
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1

Error: Unable to upgrade port: 1

[jeremyhu (Jeremy Huddleston Sequoia)]

Works for me. It looks like you have a 'bash' binary that isn't really bash.

AC_PATH_PROG(DOLT_BASH, bash)

is run to find bash, then $DOLT_BASH is used to run doltlibtool

So... what is the 'bash' binary that you have sitting around, and why isn't it really bash?

[jeremyhu (Jeremy Huddleston Sequoia)]

Also... DOLT is only used if this check fails:

if test x$GCC != xyes; then

dolt_supported=no

fi

So you have $GCC=no it seems... so what compiler are you using?

Please provide your config.log and verbose output.

[ryandesign (Ryan Carsten Schmidt)]

Replying to jeremyhu@…:

Works for me. It looks like you have a 'bash' binary that isn't really bash.

No, he has a bash that isn't as recent as Leopard's bash. Tiger comes with bash 2. dolt, which xorg-libX11 is now using, uses new bash constructs that do not exist in bash 3.0 or earlier. This is the same problem I fixed for cairo in r41758 until ​cairo fixed it upstream. I ​reported the problem to the authors of dolt at that time but nobody responded to my message. The ​webkit folks noticed the same bug. Fixed for xorg-libX11 in r46819. Please report this problem to the developers of xorg-libX11.

[ryandesign (Ryan Carsten Schmidt)]

Replying to jeremyhu@…:

So you have $GCC=no it seems... so what compiler are you using?

I think you read that code incorrectly. If $GCC is not "yes", then it sets dolt_supported to "no" and dolt is not used. So since dolt is being used, $GCC must be "yes" on his system, as it should be for all of us.

[jeremyhu (Jeremy Huddleston Sequoia)]

Replying to ryandesign@…:

Replying to jeremyhu@…:

So you have $GCC=no it seems... so what compiler are you using?

I think you read that code incorrectly. If $GCC is not "yes", then it sets dolt_supported to "no" and dolt is not used. So since dolt is being used, $GCC must be "yes" on his system, as it should be for all of us.

< yeah... too many double negatives... ;)

Still, I wonder why dolt wasn't being used on my Tiger box... hmm...

I got the problem fixed upstream, so I'm pulling in that patch: ​http://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=b4b5893f69419ff577bbaa4d18f78e4ffd729a0c

[jeremyhu (Jeremy Huddleston Sequoia)]

And I see you already patched it on your own... in r46819...

[horst@…]

Works fine. Thank you!

[(none)]

Milestone Port Bugs deleted