Opened 12 years ago

Closed 9 years ago

#18551 closed defect (worksforme)

MPlayer 1.0rc2_3 fails to build with +x264

Reported by: tkomulai+macports@… Owned by: ecronin (Eric Cronin)
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: x264 Cc: jeremyhu (Jeremy Huddleston Sequoia), weimaraner@…, daniel.pernold@…, dbevans (David B. Evans), akborder@…, Markus.Ueberall@…, aubonbeurre@…, xevean@…
Port: mplayer

Description

  • MPlayer @1.0rc2, Revision 3 (multimedia)
  • x264 @20090129 (multimedia)
% sudo port install MPlayer +binary_codecs+darwin_8+faac+macosx+osd+speex+theora+x264+xvid
[..]
/usr/bin/gcc-4.0 -I../libswscale -I../libavcodec  -DHAVE_AV_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_ISOC9X_SOURCE -I.. -I.. -I../libavutil -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -I. -I.. -I../libavutil -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -O4 -march=pentium-m -mtune=pentium-m -pipe -ffast-math -fomit-frame-pointer -mdynamic-no-pic -falign-loops=16 -DSYS_DARWIN -shared-libgcc -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DHAVE_CONFIG_H -I/opt/local/include/lzo -I/opt/local/include -I/usr/local/include -I/usr/X11R6/include -I/opt/local/include/freetype2 -I/opt/local/include  -c -o libx264.o libx264.c
libx264.c: In function 'X264_init':
libx264.c:165: error: 'x264_param_t' has no member named 'b_bframe_adaptive'
libx264.c:228: error: 'struct <anonymous>' has no member named 'b_bidir_me'
libx264.c:229: error: 'struct <anonymous>' has no member named 'b_bframe_rdo'
libx264.c:254: error: 'struct <anonymous>' has no member named 'psz_rc_eq'
make[1]: *** [libx264.o] Error 1
make: *** [libavcodec/libavcodec.a] Error 2

Change History (19)

comment:1 Changed 12 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to ecronin@…

comment:2 Changed 12 years ago by jeremyhu (Jeremy Huddleston Sequoia)

~/src/mplayer/libavcodec $ svn diff -r r15029:HEAD libx264.c 
Index: libx264.c
===================================================================
--- libx264.c	(revision 15029)
+++ libx264.c	(revision 17472)
@@ -124,6 +124,8 @@
 {
     X264Context *x4 = avctx->priv_data;
 
+    av_freep(&avctx->extradata);
+
     if(x4->enc)
         x264_encoder_close(x4->enc);
 
@@ -162,7 +164,7 @@
 
     x4->params.i_bframe = avctx->max_b_frames;
     x4->params.b_cabac = avctx->coder_type == FF_CODER_TYPE_AC;
-    x4->params.b_bframe_adaptive = avctx->b_frame_strategy;
+    x4->params.i_bframe_adaptive = avctx->b_frame_strategy;
     x4->params.i_bframe_bias = avctx->bframebias;
     x4->params.b_bframe_pyramid = avctx->flags2 & CODEC_FLAG2_BPYRAMID;
     avctx->has_b_frames= avctx->flags2 & CODEC_FLAG2_BPYRAMID ? 2 : !!avctx->max_b_frames;
@@ -227,8 +229,6 @@
     x4->params.analyse.i_me_range = avctx->me_range;
     x4->params.analyse.i_subpel_refine = avctx->me_subpel_quality;
 
-    x4->params.analyse.b_bidir_me = avctx->bidir_refine > 0;
-    x4->params.analyse.b_bframe_rdo = avctx->flags2 & CODEC_FLAG2_BRDO;
     x4->params.analyse.b_mixed_references =
         avctx->flags2 & CODEC_FLAG2_MIXED_REFS;
     x4->params.analyse.b_chroma_me = avctx->me_cmp & FF_CMP_CHROMA;

comment:3 Changed 12 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Cc: jeremyhu@… added

Cc Me!

comment:4 Changed 12 years ago by weimaraner@…

Cc: weimaraner@… added

Cc Me!

comment:5 Changed 12 years ago by daniel.pernold@…

The same here with XCode 3.1.2 and gcc 4.0.

comment:6 Changed 12 years ago by daniel.pernold@…

Cc: daniel.pernold@… added

Cc Me!

comment:7 Changed 12 years ago by dbevans (David B. Evans)

Cc: devans@… added
Keywords: x264 added

While MPlayer 1.0rc2 is the most recent formal release, it is marked as outdated on the developer's web site and is not compatible with the current x264 API. The developers recommend building from svn (same release adverse guys as ffmpeg) and upgrading to a more recent svn revision would probably solve this problem (as it has in ffmpeg-devel).

comment:8 Changed 12 years ago by daniel.pernold@…

How do i configure MacPorts to fetch the latest svn tarball? Is this possible?

comment:9 Changed 12 years ago by dbevans (David B. Evans)

One option is to rewrite the port to fetch from the developer's svn a recent revision that is known to build well but that's really up to the maintainer.

Details on how to do this are in http://guide.macports.org/ if you want to try and do this for yourself. See port inkscape-devel for an example.

comment:10 in reply to:  9 Changed 12 years ago by daniel.pernold@…

I would strongly suggest to rewrite the port, because the latest official version of MPlayer is very very old and the latest revisions compile well (as far as i know). It's also advisable because the hobbyhorse of MEncoder is its x264 or xvid encoding. A MEncoder without x264 is useless to me (and I'm sure also for a couple of other people).

comment:11 Changed 12 years ago by compconsultant@…

I have the same issue with this port. It has compiled well for me on other platforms, so, it should here also. The port should allow a more current build without users having to try and fudge their way through svn and building their own, that's the purpose of Macports.

comment:12 in reply to:  11 Changed 12 years ago by lperry (Perry Lee)

Replying to compconsultant@…:

I have the same issue with this port. It has compiled well for me on other platforms, so, it should here also. The port should allow a more current build without users having to try and fudge their way through svn and building their own, that's the purpose of Macports.

Creating a more current build was discussed awhile ago on the user list (http://www.nabble.com/MPlayer-Port-Suggestion-to20611389.html#a20611998); however, due to a lack of time and the such, it lagged behind (heh, partially my bad since I was one of the interested people that offered to help).

I've created a port request in Ticket #18672.

comment:13 Changed 12 years ago by ecronin (Eric Cronin)

Thanks, Perry. The flood of e-mails on this ticket today had me looking for the earlier thread but its filed away somewhere... I will commit #18672 assuming it compiles ok, and then people can file tickets against it if certain things are broken with svn vs 1.0rc2. I'm still way too short on free time to work on this myself.

comment:14 Changed 12 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

comment:15 Changed 12 years ago by akborder@…

Cc: akborder@… added

Cc Me!

comment:16 Changed 12 years ago by Markus.Ueberall@…

Cc: Markus.Ueberall@… added

Cc Me!

comment:17 Changed 12 years ago by aubonbeurre@…

Cc: aubonbeurre@… added

Cc Me!

comment:18 Changed 12 years ago by xevean@…

Cc: xevean@… added

Cc Me!

comment:19 Changed 9 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: worksforme
Status: newclosed

Current version (1.1) builds fine for me.

Note: See TracTickets for help on using tickets.