Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#19216 closed defect (fixed)

moria: should use ${configure.cc}

Reported by: ryandesign (Ryan Schmidt) Owned by: aschenke@…
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: Cc:
Port: moria

Description

moria builds using "cc"; it should build using the value of ${configure.cc}.

--->  Building moria
DEBUG: Executing org.macports.build (moria)
cc -O   -c -o main.o main.c
main.c: In function 'main':
main.c:227: warning: incompatible implicit declaration of built-in function 'exit'
main.c:232: warning: incompatible implicit declaration of built-in function 'exit'
main.c:281: warning: incompatible implicit declaration of built-in function 'printf'
main.c:326: warning: incompatible implicit declaration of built-in function 'sprintf'
cc -O   -c -o misc1.o misc1.c
misc1.c: In function 'place_win_monster':
misc1.c:794: warning: incompatible implicit declaration of built-in function 'abort'
cc -O   -c -o misc2.o misc2.c
misc2.c: In function 'set_options':
misc2.c:1042: warning: incompatible implicit declaration of built-in function 'sprintf'
[snip]

Attachments (1)

moria.diff (1.2 KB) - added by ryandesign (Ryan Schmidt) 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by ryandesign (Ryan Schmidt)

Attachment: moria.diff added

comment:1 Changed 12 years ago by ryandesign (Ryan Schmidt)

In the attached patch, in addition to fixing the CC variable in the Makefile, I stop the port from overriding the build phase, thus gaining the port support for nice builds and parallel builds.

comment:2 Changed 12 years ago by ryandesign (Ryan Schmidt)

With this patch the output is now:

--->  Building moria
DEBUG: Executing org.macports.build (moria)
DEBUG: port allows a parallel build
DEBUG: Environment: MACOSX_DEPLOYMENT_TARGET='10.4'
DEBUG: Assembled command: 'cd "/mp/var/macports/build/_Users_rschmidt_macports_dports_games_moria/work/umoria/source" && nice -n 10 make -j3'
/usr/bin/gcc-4.0 -O   -c -o main.o main.c
/usr/bin/gcc-4.0 -O   -c -o misc1.o misc1.c
/usr/bin/gcc-4.0 -O   -c -o misc2.o misc2.c
main.c: In function 'main':
main.c:227: warning: incompatible implicit declaration of built-in function 'exit'
main.c:232: warning: incompatible implicit declaration of built-in function 'exit'
main.c:281: warning: incompatible implicit declaration of built-in function 'printf'
main.c:326: warning: incompatible implicit declaration of built-in function 'sprintf'
/usr/bin/gcc-4.0 -O   -c -o misc3.o misc3.c
misc1.c: In function 'place_win_monster':
misc1.c:794: warning: incompatible implicit declaration of built-in function 'abort'
[snip]

comment:3 Changed 12 years ago by aschenke@…

Resolution: fixed
Status: newclosed

Committed in r49332. Thanks for the help!

comment:4 Changed 12 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.