Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#19440 closed defect (fixed)

Improper use of tabs in Python script gtk-builder-convert

Reported by: gale@… Owned by: nox@…
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: Cc:
Port: gtk2 gnome-keyring

Description

$ port list gtk2 gnome-keyring
gtk2                           @2.16.1         x11/gtk2
gnome-keyring                  @2.26.1         gnome/gnome-keyring

The python script /opt/local/bin/gtk-builder-convert from the gtk2 port contains a line indented by tabs instead of spaces. That is a python no-no!

This causes the port gnome-keyring to fail to build with the following error:

gtk-builder-convert --skip-windows gcr-certificate-basics-widget.glade gcr-certificate-basics-widget.ui
  File "/opt/local/bin/gtk-builder-convert", line 261
    print "WARNING: duplicate id \"" + node.getAttribute('id') + "\""
                                                                    ^
TabError: inconsistent use of tabs and spaces in indentation

That line of the python script does not appear in the upstream svn. Apparently it was added by MacPorts.

Please change the two tabs at the beginning of that line to a total of 16 spaces. Or remove the line altogether.

Attachments (1)

gtk-builder-convert.patch (872 bytes) - added by gale@… 15 years ago.

Download all attachments as: .zip

Change History (6)

Changed 15 years ago by gale@…

Attachment: gtk-builder-convert.patch added

comment:1 Changed 15 years ago by jmroot (Joshua Root)

Owner: changed from macports-tickets@… to nox@…

comment:2 Changed 15 years ago by nox@…

Please paste the output of port installed gtk2.

comment:3 Changed 15 years ago by nox@…

Status: newassigned

This line is not added by MacPorts. It is in the gtk 2.16.1 release.

comment:4 Changed 15 years ago by nox@…

Resolution: fixed
Status: assignedclosed

comment:5 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.