Opened 9 years ago

Closed 8 years ago

#19562 closed defect (fixed)

qt4-mac, qt4-mac-devel: reinplace didn't change anything in g++.conf

Reported by: ryandesign (Ryan Schmidt) Owned by: erickt@…
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: Cc: clubjuggler@…, MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), illogic-al@…
Port: qt4-mac, qt4-mac-devel

Description

On Mac OS X 10.5.6 Intel with Xcode 3.1.2 and MacPorts 1.7.1 with the patch from #15514 I see this:

--->  Attempting to fetch qt-mac-opensource-src-4.5.1.tar.gz from http://distfiles.macports.org/qt4-mac
--->  Verifying checksum(s) for qt4-mac
--->  Extracting qt4-mac
--->  Applying patches to qt4-mac
Warning: reinplace s| gcc$| /usr/bin/gcc-4.0| didn't change anything in /mp/var/macports/build/_Users_rschmidt_macports_dports_aqua_qt4-mac/work/qt-mac-opensource-src-4.5.1/mkspecs/common/g++.conf
--->  Configuring qt4-mac

Perhaps the reinplace is no longer needed, or maybe it needs to be updated.

Change History (3)

comment:1 Changed 9 years ago by ryandesign (Ryan Schmidt)

  • Cc mcalhoun@… added

comment:2 Changed 8 years ago by ryandesign (Ryan Schmidt)

  • Cc illogic-al@… added
  • Port qt4-mac-devel added
  • Summary changed from qt4-mac: reinplace didn't change anything in g++.conf to qt4-mac, qt4-mac-devel: reinplace didn't change anything in g++.conf

After the change in r48396 (which brought over changes from qt4-mac-devel), the message is now:

Warning: reinplace s| g++$| /usr/bin/g++-4.0| didn't change anything in /mp/var/macports/build/_Users_rschmidt_macports_dports_aqua_qt4-mac/work/qt-mac-opensource-src-4.5.2/mkspecs/common/mac-g++.conf
Warning: reinplace s| gcc$| /usr/bin/gcc-4.0| didn't change anything in /mp/var/macports/build/_Users_rschmidt_macports_dports_aqua_qt4-mac/work/qt-mac-opensource-src-4.5.2/mkspecs/common/g++.conf

The line "reinplace "s| gcc\$| ${configure.cc}|" ${worksrcpath}/mkspecs/common/g++.conf" occurs twice in the portfile; the second reinplace of course fails because the first reinplace has already replaced the string. I fixed this in r54104 in both ports.

comment:3 Changed 8 years ago by ryandesign (Ryan Schmidt)

  • Resolution set to fixed
  • Status changed from new to closed

Eh, forget the reference to r48396 as it occurred before I filed this ticket.

Rather, it looks like with the update to 4.5.2, " g++" no longer occurs in mkspecs/common/mac-g++.conf so that reinplace just gets removed from qt4-mac (done in r54105) and stays in qt4-mac-devel.

Note: See TracTickets for help on using tickets.