Opened 15 years ago
Closed 15 years ago
#19586 closed defect (fixed)
cgit: weird distfile name
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | sfiera@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.7.1 |
| Keywords: | Cc: | ||
| Port: | cgit |
Description
The cgit portfile uses a weird distfile name which contains URL parameters. This should be avoided.
It would be best to fix this in the same commit that updates the port to a new version, so I will see if I can fix this as part of #19585.
Change History (3)
comment:1 Changed 15 years ago by sfiera@…
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
comment:2 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
a) Yes, it is fixable. It has been fixed in several ports already, such as aqbanking, gtkimageview, gwenhywfar and kmmbanking.
b) None of the download links on the cgit homepage use that parameter and it does not appear to be necessary.
comment:3 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Fixed in r56015 (maintainer timeout).
Note: See
TracTickets for help on using
tickets.
This is not fixable. The distfile for cgit is generated on the fly by cgit itself; the URL parameter is what actually determines what to generated, and the apparent filename is not really used (except as a hint to clients of the name of the resultant file). If you remove the URL parameter, you'll find that the port is consistently downloading HEAD, rather than the desired tag.