traceroute build failure: label at end of compound statement

[ryandesign (Ryan Carsten Schmidt)]

traceroute doesn't build on 10.4 or 10.5 Intel:

$ port install traceroute
--->  Fetching traceroute
--->  Verifying checksum(s) for traceroute
--->  Extracting traceroute
--->  Configuring traceroute
--->  Building traceroute
Error: Target org.macports.build returned: shell command " cd "/mp/var/macports/build/_Users_rschmidt_macports_dports_net_traceroute/work/traceroute-1.4a12" && nice -n 10 make all " returned error 2
Command output: /usr/bin/gcc-4.0 -O -O2 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_SOCKIO_H=1 -DHAVE_NET_ROUTE_H=1 -DHAVE_NET_IF_DL_H=1 -DHAVE_STRERROR=1 -DHAVE_USLEEP=1 -DHAVE_SETLINEBUF=1 -DHAVE_SOCKADDR_SA_LEN=1 -DHAVE_ICMP_NEXTMTU=1  -I.  -c ./traceroute.c
./traceroute.c: In function 'wait_for_reply':
./traceroute.c:909: warning: pointer targets in passing argument 6 of 'recvfrom' differ in signedness
/usr/bin/gcc-4.0 -O -O2 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_SOCKIO_H=1 -DHAVE_NET_ROUTE_H=1 -DHAVE_NET_IF_DL_H=1 -DHAVE_STRERROR=1 -DHAVE_USLEEP=1 -DHAVE_SETLINEBUF=1 -DHAVE_SOCKADDR_SA_LEN=1 -DHAVE_ICMP_NEXTMTU=1  -I.  -c ./ifaddrlist.c
/usr/bin/gcc-4.0 -O -O2 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_SOCKIO_H=1 -DHAVE_NET_ROUTE_H=1 -DHAVE_NET_IF_DL_H=1 -DHAVE_STRERROR=1 -DHAVE_USLEEP=1 -DHAVE_SETLINEBUF=1 -DHAVE_SOCKADDR_SA_LEN=1 -DHAVE_ICMP_NEXTMTU=1  -I.  -c ./findsaddr-socket.c
./findsaddr-socket.c: In function 'findsaddr':
./findsaddr-socket.c:193: error: label at end of compound statement
make: *** [findsaddr-socket.o] Error 1

Error: Status 1 encountered during processing.

This was ​reported on macports-dev by Scott Haneda.

[ryandesign (Ryan Carsten Schmidt)]

I see the port is trying to use gcc-3.3, so that's no good. The distfile is from 2000 and that's the latest version available.

Here's ​another report of the problem and a patch.

[tobypeterson]

No clue about the gcc-3.3 crap. Committed r55545, builds fine on recent Snow Leopard.

[ryandesign (Ryan Carsten Schmidt)]

Oops, I guess we were both working on the fix at the same time. The fix you came up with for findsaddr-socket.c is about the same as the one linked to above, and works for me too on Tiger and Leopard (both Intel).

When compiling the previous version of the port on Intel PowerPC with gcc-3.3, it says:

findsaddr-socket.c: In function `findsaddr':
findsaddr-socket.c:193: warning: deprecated use of label at end of compound statement

So that's no longer needed since you fixed that, and I removed it in r55546.