Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#21070 closed defect (fixed)

port install x264 +asm fails in snow leopard

Reported by: slimscsi@… Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version: 1.8.0
Keywords: yasm Cc: dave@…
Port: x264

Description

"CPU you selected does not support x86-64 instruction set" error is reported during cc_check in ./configure

Attachments (2)

x264-asm-snow-leopard.diff (1.2 KB) - added by dave@… 11 years ago.
Patch to enable ASM on Snow Leopard.
x264-portfile-take2.diff (1.3 KB) - added by dave@… 11 years ago.
enable ams only on 64-bit snow leopard

Download all attachments as: .zip

Change History (11)

comment:1 Changed 11 years ago by jmroot (Joshua Root)

Owner: changed from macports-tickets@… to devans@…

Changed 11 years ago by dave@…

Attachment: x264-asm-snow-leopard.diff added

Patch to enable ASM on Snow Leopard.

comment:2 Changed 11 years ago by dave@…

The latest rev builds for me with ASM on Snow Leopard if we pass a —host argument to ./configure. I’ve attached a patch to the Portfile with that change that also enables ASM by default again.

comment:3 Changed 11 years ago by dave@…

Cc: dave@… added

Cc Me!

comment:4 Changed 11 years ago by lessen42@…

See also http://gcc.gnu.org/ml/gcc-bugs/2009-08/msg02260.html This affects all packages that use config.guess; forcing it to x86_64 will break on Core 1

Changed 11 years ago by dave@…

Attachment: x264-portfile-take2.diff added

enable ams only on 64-bit snow leopard

comment:5 Changed 11 years ago by dave@…

Attached a new version of the patch that only enables ASM on 64-bit Snow Leopard. That should work on Core Duo machines as well.

comment:6 Changed 11 years ago by dbevans (David B. Evans)

Status: newassigned

comment:7 Changed 11 years ago by dbevans (David B. Evans)

Keywords: x264 removed
Resolution: fixed
Status: assignedclosed

ASM optimizations enabled by default for snow leopard x86_64 in r57510. Will consider version increment after further testing to assess impact of API changes on dependents. At the very least this will require rebuilding of all dependents due to the change in library version and may break configuration tests to detect x264 (as in ffmpeg now fixed). Thanks for the patch.

comment:8 Changed 11 years ago by jmroot (Joshua Root)

I think you actually want to be passing --build rather than --host? The latter is for cross-compiling, which build_arch should never be making you do.

comment:9 Changed 11 years ago by dbevans (David B. Evans)

I agree. Fixed in r57660. Thanks for catching this.

Note: See TracTickets for help on using tickets.