Opened 11 years ago

Closed 10 years ago

#21590 closed defect (fixed)

py27-sip, py26-sip, py25-sip, py-sip won't build universal

Reported by: Veence (Vincent) Owned by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Priority: Normal Milestone:
Component: ports Version: 1.8.0
Keywords: universal Cc: bgrupe27, jabronson@…, mf2k (Frank Schima), alex_a_bordeaux@…, saispo@…, blair (Blair Zajac), danmichaelo@…, ryandesign (Ryan Schmidt), andre.david@…, michaelld (Michael Dickens)
Port: py27-sip py26-sip py25-sip py-sip

Description

py26-sip botches universal install. It does not take into account any universal flags, so it does not build universal, and it has a wired up universal configuration set to i386 and ppc. in the various .py files, leading to false universal builds thereafter. The (rather lengthy) attached patch solves (I hope) this issue.

Attachments (2)

Portfile.patch (2.8 KB) - added by Veence (Vincent) 11 years ago.
Patch for Portfile (should replace old version)
patch-sipconfig_py (350 bytes) - added by Veence (Vincent) 11 years ago.
This patch fixes a vicious bug

Download all attachments as: .zip

Change History (19)

comment:1 Changed 11 years ago by Veence (Vincent)

In fact, it's even worse. There is an insidious additional bug I chased all the afternoon. It should be *really* fixed now with another Portfile and a patch

Changed 11 years ago by Veence (Vincent)

Attachment: Portfile.patch added

Patch for Portfile (should replace old version)

Changed 11 years ago by Veence (Vincent)

Attachment: patch-sipconfig_py added

This patch fixes a vicious bug

comment:2 Changed 11 years ago by bgrupe27

Cc: bgrupe@… added

Cc Me!

comment:3 Changed 11 years ago by jabronson@…

Cc: jabronson@… added

Cc Me!

comment:4 Changed 11 years ago by mf2k (Frank Schima)

@vince: I don't have an easy way to test this because I don't use +universal when I build ports. If this patch works for you, please commit it. The port is openmaintainer.

comment:5 Changed 11 years ago by mf2k (Frank Schima)

Cc: macsforever2000@… added

Cc Me!

comment:6 Changed 11 years ago by ryandesign (Ryan Schmidt)

Cc: alex_a_bordeaux@… saispo@… blair@… added
Keywords: py26-sip removed
Port: py25-sip py-sip added
Summary: py26-sip won't build universalpy26-sip, py25-sip, py-sip won't build universal

Has duplicate #23103. Cc'ing reporter.

This issue would apply to py25-sip and py-sip as well, no? Cc'ing maintainers. (Why aren't all three ports maintained by the same maintainer?)

comment:7 Changed 11 years ago by andre.david@…

Can't we simply add

configure.universal_args-delete --disable-dependency-tracking

to the Portfile? This works for me (for py26-sip).

comment:8 Changed 11 years ago by danmichaelo@…

Cc: danmichaelo@… added

Cc Me!

comment:9 Changed 11 years ago by danmichaelo+macports@…

Cc: danmichaelo+macports@… added

Cc Me!

comment:10 Changed 11 years ago by danmichaelo+macports@…

Cc: danmichaelo+macports@… removed

Cc Me!

comment:11 Changed 11 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added

Someone please address this.

comment:12 Changed 11 years ago by mf2k (Frank Schima)

Cc: andre.david@… added

Cc reporter of #25131.

comment:13 Changed 10 years ago by andre.david@…

I hate to come back, but I tried upgrading py26-sip recently and found myself applying the same patch I mentioned above.

comment:14 Changed 10 years ago by jmroot (Joshua Root)

Port: py27-sip added
Summary: py26-sip, py25-sip, py-sip won't build universalpy27-sip, py26-sip, py25-sip, py-sip won't build universal

comment:15 Changed 10 years ago by michaelld (Michael Dickens)

Cc: michaelld@… added

Cc Me!

comment:16 Changed 10 years ago by michaelld (Michael Dickens)

Some other py2X ports to do the following to get +universal working:

variant universal {
	configure.universal_args
	configure.post_args	LFLAGS="-F${frameworks_dir} -L${prefix}/lib \
								${configure.universal_ldflags}"
	configure.post_args-append	CFLAGS="${configure.universal_cflags}"
	configure.post_args-append	CXXFLAGS="${configure.universal_cxxflags}"
}

Adding this chunk into py26-sip allows "sudo port install py26-sip +universal" to work, all of the binaries are correctly universal (as reported by 'file'), and "import sip" works for +universal or without it. I'm using MacPorts 1.9.99 (latest from SVN), OSX 10.6.4 x86_64, XCode 3.2.3, and SIP is now version 4.11.1 -- maybe things have changed enough since the original ticket was posted that this "simple" change is enough?

comment:17 Changed 10 years ago by michaelld (Michael Dickens)

Resolution: fixed
Status: newclosed

I've checked in the above change in r72221 - given that nobody is responding and these ports are either nomaintainer or openmaintainer, and this is such a simple fix. Please do:

sudo port clean py2X-sip
sudo port selfupdate
sudo port install py2X-sip

and see if it works for you. I'm closing this ticket as fixed; please reopen if the changes don't work for you.

Note: See TracTickets for help on using tickets.