Opened 15 years ago
Closed 8 years ago
#21806 closed defect (wontfix)
Wireshark no_x11 installs without GUI
| Reported by: | lkraider (Paul Eipper) | Owned by: | opendarwin.org@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.8.1 |
| Keywords: | haspatch | Cc: | maxkalashnikov@…, boris.dusek@…, pavel@…, geekosaur, daniel@…, pokui@… |
| Port: | wireshark |
Description
I have gtk2 installed as +no_x11 +quartz -x11
After trying to install wireshark, it builds without gui, because no_x11 disables gtk2 in its Portfile.
Trying to set -no_x11 doesn't work since gtk2 is already built with it enabled, and port returns an error for that.
Since the build works fine with gtk2 +no_x11, I propose the no_x11 be renamed to no_gui on the wireshark Portfile.
Attachments (1)
Change History (14)
comment:1 Changed 15 years ago by mf2k (Frank Schima)
| Owner: | changed from macports-tickets@… to opendarwin.org@… |
|---|---|
| Port: | wireshark added |
comment:2 Changed 15 years ago by maxkalashnikov@…
| Cc: | maxkalashnikov@… added |
|---|
comment:3 Changed 13 years ago by boris.dusek@…
I agree too. I have gtk2 with +no_x11 and wireshark installed without no_x11, and it works fine.
comment:9 follow-up: 10 Changed 11 years ago by pokui@…
| Cc: | pokui@… added |
|---|
I agree with the previous comments. +no_x11 does not necessarily imply +no_quartz. no_gui or no_gtk would better portray the meaning implied here.
Additionally one could print a message to the screen if someone has +no_x11 to the effect that to disable gtk altogether one needs +no_gui.
comment:10 follow-up: 11 Changed 11 years ago by pokui@…
Replying to pokui@…:
I agree with the previous comments. +no_x11 does not necessarily imply +no_quartz. no_gui or no_gtk would better portray the meaning implied here.
After thinking about this a bit +no_gtk2 etc may violate POLA. Another solution is to add a +quartz that requires +no_x11. If someone has both +no_x11 and +quartz enabled then gtk2 should not be disabled, If someone has only +no_x11 then the current interpretation could be kept.
Either way I just had to edit the portfile to get it to build against my quartz'ed gtk2 for the latest update to the port.
comment:11 Changed 10 years ago by pokui@…
Replying to pokui@…:
Replying to pokui@…:
I agree with the previous comments. +no_x11 does not necessarily imply +no_quartz. no_gui or no_gtk would better portray the meaning implied here.
After thinking about this a bit +no_gtk2 etc may violate POLA. Another solution is to add a +quartz that requires +no_x11. If someone has both +no_x11 and +quartz enabled then gtk2 should not be disabled, If someone has only +no_x11 then the current interpretation could be kept.
The attached patch works exactly like the gtk2 port and adds support for the +quartz variant and ensures it's listed as a conflict with +x11.
comment:12 Changed 10 years ago by ghosthound
| Keywords: | haspatch added |
|---|
Changed 10 years ago by pokui@…
| Attachment: | wireshark-add-quartz.patch added |
|---|
add quartz variant AND active_variants port group.
comment:13 Changed 8 years ago by ghosthound
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Please try the new wireshark2 port. It builds with qt5 and is the direction that upstream is taking. If that does not work for you, please reopen and comment as to why.
Cc Me!