Opened 15 years ago
Closed 13 years ago
#22043 closed submission (wontfix)
new port: libv8
| Reported by: | cowboyd@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | google v8 javascript | Cc: | markus@… |
| Port: | libv8 |
Description
Hi All,
I've created a portfile for libv8, the library for embedding google's V8 javascript interpreter.
This is my first port. I've tried to read the instructions and conform to convention, so apologies for anywhere I might have transgressed.
Attachments (1)
Change History (9)
comment:1 Changed 15 years ago by cowboyd@…
| Cc: | cowboyd@… added |
|---|
comment:2 follow-up: 4 Changed 14 years ago by cowboyd@…
Bump. Is there anything special I need to do for somebody to look at this?
comment:3 Changed 14 years ago by mf2k (Frank Schima)
| Cc: | cowboyd@… removed |
|---|---|
| Port: | libv8 added |
| Version: | 1.8.0 |
comment:4 Changed 14 years ago by jmroot (Joshua Root)
Replying to cowboyd@…:
Bump. Is there anything special I need to do for somebody to look at this?
There are a lot of ports in the submission queue. If you think a ticket has been forgotten, ping the mailing list or ask someone on IRC to take a look.
Feedback on this port:
- Normally a port should be the latest stable release. A development/unstable/prerelease version would be called libv8-devel.
- 0.4.0-devel is not a good version string to use, as it will presumably not change when you switch to a newer svn revision that is still prior to the stable 0.4.0 release. You might like to put the svn revision on the end of the version instead.
- If scons is only needed at build time, it should be a depends_build rather than a depends_lib.
- A variant is not the right way to choose the architecture to build for. Instead you should look at the value of the build_arch option.
- It would be nicer to override the destroot phase entirely instead of clearing all the args and using a really long destroot.cmd.
- You should do 'use_configure no' rather than 'configure {}', as the former will correctly disable the default universal variant.
- Why do you need to set a blank test phase?
comment:5 follow-up: 7 Changed 14 years ago by cowboyd@…
Thanks for the feedback! That's exactly the type of thing I'm looking for. I'll try to integrate these changes and submit the updated port
cheers, Charles
comment:7 Changed 14 years ago by markus@…
Replying to cowboyd@…:
Thanks for the feedback! That's exactly the type of thing I'm looking for. I'll try to integrate these changes and submit the updated port
Hi Charles!
Any success with the integration?
Regards,
Markus
comment:8 Changed 13 years ago by jmroot (Joshua Root)
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Closing as nothing seems to be happening here.
Cc Me!