Opened 14 years ago

Closed 14 years ago

#22106 closed submission (fixed)

apbs-mpi-1.1.0 package

Reported by: howarth@… Owned by: mf2k (Frank Schima)
Priority: Normal Milestone:
Component: ports Version: 1.8.1
Keywords: science Cc:
Port: apbs-mpi

Description

This package provides the mpi build of apbs. Note that the apbs utility programs are provided via a depends on the apbs package. The python support for apbs is not built in this package because it is incompatible with the mpi build of apbs.

Attachments (1)

Portfile (2.0 KB) - added by howarth@… 14 years ago.
update Portfile to 1.2.0 release and add fixes.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 14 years ago by mf2k (Frank Schima)

My initial comments:

  • Your email address should be obfuscated.
  • The version is hardcoded a few places. ${version} should be used instead.
  • The distfiles line is redundant and has the version hardcoded, so it should be removed.
  • In destroot, directories are moved with the system command, but this is frowned on. Tcl commands should be used. However the guide does not not really give a good way to do this. Are there too many files to use a for each loop like in the qt4-mac portfile?

Changed 14 years ago by howarth@…

Attachment: Portfile added

update Portfile to 1.2.0 release and add fixes.

comment:2 Changed 14 years ago by howarth@…

The distfiles line needs to be used because the package name (abps-mpi)
is not the same as the tarball package name. There are too many files and subdirectories
to use the qt4-mac approach. The tcl extensions should be enhanced to support recursive
copies.

comment:3 Changed 14 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to macsforever2000@…
Status: newassigned

comment:4 Changed 14 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: assignedclosed

Added in r61439. I replaced the distfiles and worksrcdir lines with distname to simplify.

Note: See TracTickets for help on using tickets.