Opened 15 years ago

Closed 13 years ago

#22157 closed update (fixed)

xmms2: update to 0.6DrMattDestruction

Reported by: manphiz@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.8.1
Keywords: haspatch Cc:
Port: xmms2

Description

The attached patch updates xmms2 to the latest release 0.6DrMattDestruction. The patch is required to prevent xmms2 from "Abort trap" due to a hand-coded length of saddr_path. However python development support currently cannot be activated as pyrexc path cannot be found even though pyrex correspond to the python version is already installed. So lines relevant to python are now temporarily commented. Suggestions are welcome. Thanks.

Attachments (2)

patch-src-lib-xmmsipc-socket_unix.c.diff (890 bytes) - added by manphiz@… 15 years ago.
This patch is supposed to be put in "files", which fixes a bug that causes "Abort trap" when using xmms2. See http://bugs.xmms2.xmms.se/view.php?id=2263 and http://bugs.xmms2.xmms.se/view.php?id=2274
patch-macports-xmms2.diff (4.3 KB) - added by manphiz@… 14 years ago.

Download all attachments as: .zip

Change History (10)

Changed 15 years ago by manphiz@…

This patch is supposed to be put in "files", which fixes a bug that causes "Abort trap" when using xmms2. See http://bugs.xmms2.xmms.se/view.php?id=2263 and http://bugs.xmms2.xmms.se/view.php?id=2274

comment:1 Changed 15 years ago by manphiz@…

Another thing is, it seems that macports automatically append --disable-dependency-tracking switch to configure.args, which cannot be recognized by waf. I'm currently specifying configure.universal_args as empty to allow +universal variant to be able to build. Suggestions are welcome. Thanks.

comment:2 in reply to:  1 Changed 14 years ago by jmroot (Joshua Root)

Replying to manphiz@…:

Another thing is, it seems that macports automatically append --disable-dependency-tracking switch to configure.args, which cannot be recognized by waf. I'm currently specifying configure.universal_args as empty to allow +universal variant to be able to build. Suggestions are welcome. Thanks.

That is entirely reasonable.

comment:3 in reply to:  1 Changed 14 years ago by timur@…

Well, patching worked, but then sudo port install xmms2 fails with:

bryaugh:xmms2 timur$ sudo port install xmms2
--->  Computing dependencies for xmms2Error: Unable to execute port: Can't install ffmpeg-devel because conflicting ports are installed: ffmpeg

Suggestions?

comment:4 Changed 14 years ago by timur@…

OK, now it works. I had to manually change ffmpeg-devel and libsdl-devel to ffmeg and libsdl, respectively, in the Portfile.

Changed 14 years ago by manphiz@…

Attachment: patch-macports-xmms2.diff added

comment:5 in reply to:  4 Changed 14 years ago by manphiz@…

Replying to timur@…:

OK, now it works. I had to manually change ffmpeg-devel and libsdl-devel to ffmeg and libsdl, respectively, in the Portfile.

Now I've added a new variant `dev_dep' to select the -devel version for ffmpeg, libsdl, speex respectively, and changed the default ones depends_lib to stable ones.

Any methods in macports to specify parallel dependencies? So that such ugly trick won't be needed. Thanks.

comment:6 Changed 14 years ago by nerdling (Jeremy Lavergne)

I would suggest using "no_lang" as a variant that disables all the languages rather than doing each language separately. Also, consider having them build by default.

comment:7 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned
Summary: Upgrade xmms2 to 0.6DrMattDestructionxmms2: update to 0.6DrMattDestruction

comment:8 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

I've updated the port to 0.6DrMattDestruction in r83981 with several changes from the patch supplied here.

Removing the patch block that reinplaced the shebang line in the python scripts was incorrect; we want that reinplace done so that the scripts are run with the specified python, not with whatever python the user happens to have selected.

Using a "dev_dep" variant is not the way we do that in MacPorts. Instead, these dependencies are written using the path: style (instead of the more usual port: style) to allow the -devel ports to satisfy the dependencies, if the user has installed those -devel ports first.

I used the cpp, perl and ruby variants as supplied; using a single "no_lang" variant would be worse, not better; developers are interested in the single language they're currently developing in. Similarly, having all languages build by default would unnecessarily bring in dependencies most users don't need; boost in particular is huge. Ideally these variants would be deleted and turned into standalone ports but I don't have time to deal with that right now.

Note: See TracTickets for help on using tickets.