Opened 14 years ago

Closed 14 years ago

#22212 closed defect (fixed)

pidgin, finch: restore perl and make it a variant

Reported by: nefar@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.8.1
Keywords: Cc:
Port: pidgin, finch

Description (last modified by ryandesign (Ryan Carsten Schmidt))

This checkin made it impossible to build *with* perl.

The change should have been to build a variant with a no_perl option (Since with perl is after all default).

Attachments (1)

Portfile.patch (706 bytes) - added by nefar@… 14 years ago.

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by nefar@…

Attachment: Portfile.patch added

comment:1 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Owner: changed from macports-tickets@… to ryandesign@…
Port: finch added
Status: newassigned
Summary: pidgin update: restore perl and make it a variantpidgin, finch: restore perl and make it a variant

comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

I reenabled perl in pidgin and finch in r68115. I didn't see a reason to add a no_perl variant. (Or is there a reason why a user would want to disable perl support? It's not as if doing so would save them from having to install perl, since perl is already an indirect dependency.)

I also added an fs-traverse block to delete the perllocal.pod file that then got created. No port should create or claim ownership of this file.

comment:3 in reply to:  2 ; Changed 14 years ago by nefar@…

Resolution: fixed
Status: closedreopened

Replying to ryandesign@…:

I reenabled perl in pidgin and finch in r68115. I didn't see a reason to add a no_perl variant. (Or is there a reason why a user would want to disable perl support? It's not as if doing so would save them from having to install perl, since perl is already an indirect dependency.)

I also added an fs-traverse block to delete the perllocal.pod file that then got created. No port should create or claim ownership of this file.

It seems you also disabled the ability of having both finch and pidgin installed. I'm now getting this error:

---> Computing dependencies for finchError: Unable to execute port: Can't install finch because conflicting ports are installed: pidgin

However, there's absolutely no reason why both should not be able to co-exist.

comment:4 in reply to:  3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: reopenedclosed

Replying to nefar@…:

It seems you also disabled the ability of having both finch and pidgin installed.

Yes, I did. r68115 contained fixes for many tickets, and this fix which didn't have a ticket, but I didn't think I needed to create a ticket and describe the problem because I didn't think it was a controversial change.

there's absolutely no reason why both should not be able to co-exist.

Well, yes there is. pidgin and finch have files in common and therefore cannot be active at the same time. That's why I marked them as conflicting. If I hadn't done so, you would get an error like this:

$ sudo port -v activate finch
--->  Activating finch
Error: port activate failed: Image error: /opt/local/include/libpurple/account.h is being used by the active pidgin port.  Please deactivate this port first, or use 'port -f activate finch' to force the activation.

/opt/local/include/libpurple/account.h is just the first of the conflicting files; there are 245 others.

If you have a fix that allows both ports to coexist (i.e. have no files in common), please file a new ticket and attach a patch. One solution might be to create a third port (libpurple?) to contain the parts that are common to pidgin and finch, and have both pidgin and finch depend on it. Or perhaps we should rethink why there are two ports at all; perhaps it makes more sense to delete finch and add a variant for whatever it's doing to pidgin. (What are the differences? Why would someone want both of them installed?)

Note: See TracTickets for help on using tickets.