Opened 7 years ago

Last modified 2 months ago

#22590 new defect

rsync can silently corrupt OS X files due to lack of extended attribute support

Reported by: ned-deily (Ned Deily) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.8.1
Keywords: Cc: nonstop.server@…, egall@…
Port: rsync

Description (last modified by macsforever2000@…)

The MacPorts rsync lacks the Apple-specific modifications to support extended attribute and resource fork copy.

        -E, --extended-attributes   copy extended attributes, resource forks

vs

        -E, --executability         preserve executability

This is particularly nasty because at least one popular port (git-core) pulls in rsync as a dependency and -aE is a valid option in both versions of rsync. So, when users install git-core via MacPorts, they may not realize that rsync is also being installed and, if they use rsync to backup OS X files, they may not find out until it is too late that crucial HFS metadata (like resource forks and other extended attributes) were not copied as expected if the Apple rsync had been used.

I would think the best solution would be to forward port the Apple -E changes but, if that's not possible, there should be some other change, perhaps a warning when -E is selected. Or remove the dependency in git-core on rsync. As it stands, considering the popularity of rsync as a backup solution, it is way too easy for users to end up with silently corrupted files.

Change History (7)

comment:1 Changed 7 years ago by macsforever2000@…

  • Description modified (diff)
  • Owner changed from macports-tickets@… to simon@…

comment:2 Changed 7 years ago by danielluke (Daniel J. Luke)

We could also recommend putting system directories before macports ones in $PATH (which we used to do)...

comment:3 Changed 6 years ago by simon@…

  • Owner changed from simon@… to macports-tickets@…

comment:4 Changed 4 years ago by ryandesign (Ryan Schmidt)

  • Owner changed from macports-tickets@… to jimjag@…

comment:5 Changed 4 years ago by nonstop.server@…

  • Cc nonstop.server@… added

Cc Me!

comment:6 Changed 2 years ago by egall@…

  • Cc egall@… added

Cc Me!

comment:7 Changed 2 months ago by raimue (Rainer Müller)

  • Owner changed from jimjag@… to macports-tickets@…
Note: See TracTickets for help on using tickets.