New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #22590 (new defect)

Opened 4 years ago

Last modified 21 months ago

rsync can silently corrupt OS X files due to lack of extended attribute support

Reported by: nad@… Owned by: jimjag@…
Priority: Normal Milestone:
Component: ports Version: 1.8.1
Keywords: Cc: nonstop.server@…
Port: rsync

Description (last modified by macsforever2000@…) (diff)

The MacPorts rsync lacks the Apple-specific modifications to support extended attribute and resource fork copy.

        -E, --extended-attributes   copy extended attributes, resource forks

vs

        -E, --executability         preserve executability

This is particularly nasty because at least one popular port (git-core) pulls in rsync as a dependency and -aE is a valid option in both versions of rsync. So, when users install git-core via MacPorts, they may not realize that rsync is also being installed and, if they use rsync to backup OS X files, they may not find out until it is too late that crucial HFS metadata (like resource forks and other extended attributes) were not copied as expected if the Apple rsync had been used.

I would think the best solution would be to forward port the Apple -E changes but, if that's not possible, there should be some other change, perhaps a warning when -E is selected. Or remove the dependency in git-core on rsync. As it stands, considering the popularity of rsync as a backup solution, it is way too easy for users to end up with silently corrupted files.

Change History

comment:1 Changed 4 years ago by macsforever2000@…

  • Owner changed from macports-tickets@… to simon@…
  • Description modified (diff)

comment:2 Changed 4 years ago by dluke@…

We could also recommend putting system directories before macports ones in $PATH (which we used to do)...

comment:3 Changed 4 years ago by simon@…

  • Owner changed from simon@… to macports-tickets@…

comment:4 Changed 21 months ago by ryandesign@…

  • Owner changed from macports-tickets@… to jimjag@…

comment:5 Changed 21 months ago by nonstop.server@…

  • Cc nonstop.server@… added

Cc Me!

Note: See TracTickets for help on using tickets.