Opened 11 years ago

Closed 11 years ago

#22644 closed defect (fixed)

VLC preference dialog not working

Reported by: vaulse@… Owned by: mnick@…
Priority: Normal Milestone:
Component: ports Version: 1.8.1
Keywords: Cc: raimue (Rainer Müller), cavinsays@…, ryandesign (Ryan Schmidt)
Port: vlc

Description

I installed the current vlc port under 10.5.8 (Intel). The build completed without error, but when I select "Preferences" from the "VLC" menu, nothing happens. I get the following entries in the system log:

VLC[48253]: *** +[NSString stringWithUTF8String:]: NULL cString
[0x0-0x99e99e].org.videolan.vlc[48253]: [0x4c12528] main interface error: option rtsp-tcp does not exist
[0x0-0x99e99e].org.videolan.vlc[48253]: [0x4c12528] macosx interface error: option rtsp-tcp does not exist

The developer's build works as expected on my system.

Attachments (1)

patch-modules-gui-macosx-simple_prefs.diff (620 bytes) - added by kalen@… 11 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to mnick@…

comment:2 Changed 11 years ago by raimue (Rainer Müller)

Cc: raimue@… added

Seeing the exact same message with VLC @1.0.4 on Mac OS X 10.6.2.

comment:3 Changed 11 years ago by cavinsays@…

As am I on 10.6.2 with VLC 1.0.5 64-bit.

comment:4 Changed 11 years ago by cavinsays@…

Cc: cavinsays@… added

Cc Me!

comment:5 Changed 11 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added

Cc Me!

Changed 11 years ago by kalen@…

comment:6 Changed 11 years ago by kalen@…

First of all, sorry for my bad english.
Added patch corrects error showing VLC Prefernces by inserting simple condition in file modules/gui/macosx/simple_prefs.m
Error was in void

- (void)setupButton: (NSButton *)object forBoolValue: (const char *)name

in line

[object setToolTip: [NSString stringWithUTF8String: config_GetLabel( p_intf, name )]];

Void produced error when config_GetLabel( p_intf, name ) returns NULL. You may see it in system log by opening Console.
Corrected string is there:

   if( config_GetLabel( p_intf, name ) )
       [object setToolTip: [NSString stringWithUTF8String: config_GetLabel( p_intf, name )]];

comment:7 Changed 11 years ago by ryandesign (Ryan Schmidt)

Remember WikiFormatting, please. I believe I corrected the formatting in your post above.

So why does the official dmg of VLC 1.0.5 not have the problem but our source build of it does?

Has this patch of yours already been applied to the VLC sources upstream?

comment:8 in reply to:  7 Changed 11 years ago by kalen@…

Replying to ryandesign@…:

Remember WikiFormatting, please. I believe I corrected the formatting in your post above.

So why does the official dmg of VLC 1.0.5 not have the problem but our source build of it does?

Has this patch of yours already been applied to the VLC sources upstream?

Sorry for formatting, this is my very first post in MacPorts :)

No, this patch I've created about one hour ago, so it doesnt applied to VLC source upstream. Can you help me with this? I'm not shure I'll do this because of my bad english. Thank you for help!

comment:9 Changed 11 years ago by cavinsays@…

kalen's patch worked for me. Thanks :)

comment:10 Changed 11 years ago by ryandesign (Ryan Schmidt)

Any update on this situation? Has anybody informed the developers of VLC about this problem and our proposed solution? If not, somebody should please do so.

comment:11 Changed 11 years ago by mnick@…

Resolution: fixed
Status: newclosed

Sorry, this ticket somehow ended up in my spam folder... Should be fixed in r66366

Note: See TracTickets for help on using tickets.