Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#22790 closed update (fixed)

Updated swi-prolog portfile for version 5.8.2

Reported by: pmoura (Paulo Moura) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: J.Wielemaker@…
Port: swi-prolog

Description

Updated swi-prolog portfile for version 5.8.2.

Attachments (1)

Portfile-swi-prolog.diff (241 bytes) - added by pmoura (Paulo Moura) 14 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 14 years ago by jmroot (Joshua Root)

Keywords: haspatch maintainer added
Owner: changed from macports-tickets@… to J.Wielemaker@…
Version: 1.8.1

comment:2 Changed 14 years ago by jmroot (Joshua Root)

Patch won't apply to the portfile in svn.

comment:3 Changed 14 years ago by pmoura (Paulo Moura)

Maybe because the portfile was updated after the patch was submitted? I have just updated the patch file. Could you try again please? Thanks.

comment:4 Changed 14 years ago by pmoura (Paulo Moura)

Updated the patch file for SWI-Prolog 5.8.3.

comment:5 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: J.Wielemaker@… added
Owner: changed from J.Wielemaker@… to ryandesign@…

comment:6 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

I committed the update in r63830, though I didn't add the ncursesw dependency, because the port already has an ncurses dependency, and ncurses depends on ncursesw. If you feel strongly the ncursesw dependency should still be added, let me know.

comment:7 Changed 14 years ago by pmoura (Paulo Moura)

I don't think there is a problem in leaving the"ncursesw" dependency. However, I have just found a problem with the patch file :( Somehow, the dependency on "port:xorg-libs" got lost. This dependency is also missing from the previous portfile version for SWI-Prolog 5.8.0. I'm going to update the patch file in a few minutes. But I don't have permission to reopen the ticket.

Changed 14 years ago by pmoura (Paulo Moura)

Attachment: Portfile-swi-prolog.diff added

comment:8 Changed 14 years ago by pmoura (Paulo Moura)

The updated patch file is in. It patches the portfile committed in r63830. Sorry for the mishap.

comment:9 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

The xorg-libs dependency was deliberately deleted by Jeremy in r61869 because "This doesn't link against X11 libs". But as far as I can tell, it does: it links with libICE, libSM, libX11, libXau, libXdmcp, libXext, libXft, libXinerama, libXpm, libXrender, libXt. I added the dependency back in and bumped the port revision in r63854.

comment:10 Changed 14 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: closedreopened

I did not see the dependency.

If it links against those libs, then depend on those libs. Don't depend on xorg-libs

comment:11 Changed 14 years ago by jeremyhu (Jeremy Huddleston Sequoia)

This list will satisfy those dependencies that you explicitly list above... but I'm still not seeing what file has the dependency.

port:Xft2
port:xpm
port:xorg-libXinerama
port:xorg-libXt

comment:12 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

$ otool -L /opt/local/lib/swipl-5.8.3/xpce-6.6.66/lib/i386-darwin10.2.0/pl2xpce.dylib
/opt/local/lib/swipl-5.8.3/xpce-6.6.66/lib/i386-darwin10.2.0/pl2xpce.dylib:
	/opt/local/lib/swipl-5.8.3/lib/i386-darwin10.2.0/libpl.dylib (compatibility version 0.0.0, current version 5.8.3)
	/opt/local/lib/libXpm.4.dylib (compatibility version 16.0.0, current version 16.0.0)
	/opt/local/lib/libjpeg.7.dylib (compatibility version 8.0.0, current version 8.0.0)
	/opt/local/lib/libXinerama.1.dylib (compatibility version 2.0.0, current version 2.0.0)
	/opt/local/lib/libXext.6.dylib (compatibility version 11.0.0, current version 11.0.0)
	/opt/local/lib/libXt.6.dylib (compatibility version 7.0.0, current version 7.0.0)
	/opt/local/lib/libX11.6.dylib (compatibility version 10.0.0, current version 10.0.0)
	/opt/local/lib/libSM.6.dylib (compatibility version 7.0.0, current version 7.1.0)
	/opt/local/lib/libICE.6.dylib (compatibility version 10.0.0, current version 10.0.0)
	/opt/local/lib/libXft.2.dylib (compatibility version 4.0.0, current version 4.13.0)
	/opt/local/lib/libXrender.1.dylib (compatibility version 5.0.0, current version 5.0.0)
	/opt/local/lib/libfontconfig.1.dylib (compatibility version 6.0.0, current version 6.4.0)
	/opt/local/lib/libexpat.1.dylib (compatibility version 7.0.0, current version 7.2.0)
	/opt/local/lib/libiconv.2.dylib (compatibility version 8.0.0, current version 8.0.0)
	/opt/local/lib/libfreetype.6.dylib (compatibility version 11.0.0, current version 11.0.0)
	/opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.3)
	/opt/local/lib/libXau.6.dylib (compatibility version 7.0.0, current version 7.0.0)
	/opt/local/lib/libXdmcp.6.dylib (compatibility version 7.0.0, current version 7.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.0.0)

comment:13 Changed 14 years ago by pmoura (Paulo Moura)

Given the long list of dependencies above for the SWI-Prolog pl2xpce.dylib library, I find it simple and more resilient to just declare a dependency on xorg-libs. After all, the SWI-Prolog XPCE package is a X11 application.

comment:14 Changed 14 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: reopenedclosed

xorg-libs is a transitional package that pulls in WAY too much. I fixed it in:

r63946 r63947

comment:15 Changed 14 years ago by pmoura (Paulo Moura)

Thanks :-) It seems that "expat" is a dependency in both Leopard and Snow Leopard, although the swi-prolog and swi-prolog-devel portfiles only make that explicit for Leopard. But "expat" is a dependency for "fontconfig", which in turn is a dependency for Xft2, which is explicitly listed as a dependency in the portfiles. Thus, I guess there is no need to further update the portfiles.

Note: See TracTickets for help on using tickets.