Opened 14 years ago

Closed 6 years ago

#22977 closed enhancement (fixed)

postgresql8x/9x should have tablefunc variant

Reported by: russm-trac-macports-org@… Owned by: jyrkiwahlstedt
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: chepra@…, dh@…, dark.panda+macports@…, nonstop.server@…
Port: postgresql80 postgresql81 postgresql82 postgresql83 postgresql84 postgresql90 postgresql91 postgresql-devel

Description

postgresql should either build more of the contrib section, or allow the contrib items that are not in the default build to be selected as variants. the attached patch adds a "tablefunc" variant that adds that contrib item to the build.

Attachments (5)

portfile-tablefunc-variant.diff (385 bytes) - added by russm-trac-macports-org@… 14 years ago.
add "tablefunc" variant to postgresql84 and postgresql85 Portfiles
postgresql-9.1.patch.diff (1.1 KB) - added by dh@… 12 years ago.
Portfile-postgresql90 (4.6 KB) - added by dark.panda+macports@… 12 years ago.
PostgreSQL 9.0 Portfile with contrib module whitelist
Portfile-postgresql91 (4.6 KB) - added by dark.panda+macports@… 12 years ago.
PostgreSQL 9.1 Portfile with contrib module whitelist
Portfile-postgresql92 (4.7 KB) - added by dark.panda+macports@… 12 years ago.
PostgreSQL 9.2 Portfile with contrib module whitelist

Download all attachments as: .zip

Change History (18)

Changed 14 years ago by russm-trac-macports-org@…

add "tablefunc" variant to postgresql84 and postgresql85 Portfiles

comment:1 Changed 14 years ago by mf2k (Frank Schima)

Cc: jwa@… added
Keywords: haspatch added
Owner: changed from macports-tickets@… to mww@…
Version: 1.8.1

comment:2 Changed 13 years ago by dh@…

Cc: dh@… added

Cc Me!

comment:3 Changed 13 years ago by dh@…

Port: postgresql90 added

Wondering where this ticket stands? Currently postgresql9x ports also only install a subset of the contrib modules. It would be great to add tablefunc either to that default set or as a variant.

comment:4 Changed 13 years ago by jmroot (Joshua Root)

Cc: chepra@… added
Port: postgresql80 postgresql81 postgresql82 postgresql83 postgresql91 postgresql-devel added; postgresql85 removed
Summary: postgresql8x should have tablefunc variantpostgresql8x/9x should have tablefunc variant

comment:5 Changed 12 years ago by jeabraham

Can't someone do this? Is there a way to parameterize the contrib line? I'm pretty new at this but if anyone would point me in the right direction I could take a stab at it.

Should it be a variant for each contrib?

What I've done is make my own Portfile and add tablefunc to the end of the contribs line:

  • set contribs "adminpack dblink fuzzystrmatch lo uuid-ossp pg_buffercache pg_trgm pgcrypto tsearch2 vacuumlo xml2"

+ set contribs "adminpack dblink fuzzystrmatch lo uuid-ossp pg_buffercache pg_trgm pgcrypto tsearch2 vacuumlo xml2 tablefunc"

Changed 12 years ago by dh@…

Attachment: postgresql-9.1.patch.diff added

comment:6 Changed 12 years ago by dh@…

I've added the patch I've been using the last couple of years for postgres 8x/9x. It adds a variant per extension which is not necessarily the best approach, but at least it solves the problem.

comment:7 Changed 12 years ago by jyrkiwahlstedt

Resolution: fixed
Status: newclosed

Now the port installs most of the contribs, incl. tablefunc, but if some extension is missing, let me know

comment:8 Changed 12 years ago by dh@…

Resolution: fixed
Status: closedreopened

Its missing most of the extensions I had as variants in the patch I attached earlier, eg hstore, btree_gist, ltree, citext. Can these either be added to the contribs line, or variants added as per that patch?

comment:9 Changed 12 years ago by dark.panda+macports@…

Attached are versions of the postgresql92, postgresql91 and postgresql90 Portfiles that build all available modules in the contrib directory via a blacklist of modules rather than the current whitelist system that's used.

Changed 12 years ago by dark.panda+macports@…

Attachment: Portfile-postgresql90 added

PostgreSQL 9.0 Portfile with contrib module whitelist

Changed 12 years ago by dark.panda+macports@…

Attachment: Portfile-postgresql91 added

PostgreSQL 9.1 Portfile with contrib module whitelist

Changed 12 years ago by dark.panda+macports@…

Attachment: Portfile-postgresql92 added

PostgreSQL 9.2 Portfile with contrib module whitelist

comment:10 Changed 12 years ago by dark.panda+macports@…

Cc: dark.panda+macports@… added

Cc Me!

comment:11 Changed 12 years ago by nonstop.server@…

Cc: nonstop.server@… added

Cc Me!

comment:12 Changed 7 years ago by mf2k (Frank Schima)

Cc: jyrkiwahlstedt removed
Owner: changed from mww@… to jyrkiwahlstedt
Status: reopenedassigned

comment:13 Changed 6 years ago by jyrkiwahlstedt

Resolution: fixed
Status: assignedclosed

All postgresql ports nowadays build all contrib modules, unless they are specifically written for some other platform (e.g. sepgsql)

Note: See TracTickets for help on using tickets.