Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#23151 closed defect (fixed)

Patch available: libofa does not build on Snow Leopard

Reported by: kthenriksson@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.8.2
Keywords: haspatch Cc:
Port: libofa

Description

As it stands, libofa has

  1. A strange build error with the "vDSP" FFT method that would produce incorrect results anyway (see http://lists.musicbrainz.org/pipermail/musicbrainz-devel/2007-July/002204.html)
  1. An incompatibility with modern gcc (mentioned here: http://code.google.com/p/musicip-libofa/issues/detail?id=3)
  1. An old version of libtool that prevents a universal build even when these issues are addressed (I can't find any references: I think no one cares enough about a universal build of this library to bother.)

It currently does not build; this patch fixes all three problems mentioned above, and allows a universal build. If this patch could be applied I'd be appreciative.

Attachments (1)

libofa.patch (2.3 KB) - added by kthenriksson@… 11 years ago.
libofa patch

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by kthenriksson@…

Attachment: libofa.patch added

libofa patch

comment:1 Changed 11 years ago by jmroot (Joshua Root)

Keywords: haspatch added

comment:2 Changed 10 years ago by kthenriksson@…

Could someone who has the ability please commit this? Or if there is some problem indicate what it is? This package is needed in order to build MusicBrainz Picard, and I think I've documented above why this patch is needed. Thanks.

comment:3 Changed 10 years ago by anddam (Andrea D'Amore)

Resolution: fixed
Status: newclosed

Committed in r68113

comment:4 Changed 10 years ago by ryandesign (Ryan Schmidt)

Added the new patchfiles in r68142.

Note: See TracTickets for help on using tickets.